Skip to content

Vendor the source-conflict register at rulespec-us ad03b325 - #10445

Merged
MaxGhenis merged 1 commit into
mainfrom
source-conflict-register-cites
Oct 25, 2026
Merged

MaxGhenis merged 1 commit into
mainfrom
source-conflict-register-cites

Conversation

@MaxGhenis

@MaxGhenis MaxGhenis commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

axiom: n/a (vendors the shared register; no rule or model change)

What this changes

This PR vendors source_conflicts/known-source-conflicts.yaml at TheAxiomFoundation/rulespec-us@ad03b325. That commit merges TheAxiomFoundation/rulespec-us#1908, and it also includes TheAxiomFoundation/rulespec-us#1907. scripts/update_source_conflicts.py --commit ad03b32553749edc6e332b815487a9311ef9ed58 wrote both known-source-conflicts.yaml and pin.yaml.

  • rulespec-us#1908 repins the nine implementations marked in Mark nine source conflicts now in the shared register #10441 to eeaf8096, the Mark nine source conflicts now in the shared register #10441 merge commit, and sets cites_entry: true on each. With this pin, test_registered_implementations_carry_their_marker requires those nine markers. I checked this by removing the niit_magi.py marker locally: that test failed (1 failed, 102 passed). Restoring the marker made it pass again.
  • rulespec-us#1907 adds oasdi-dual-entitlement-zero-after-age-reduction and oasdi-parent-entitlement-count-interval. It also replaces the proposed record on oasdi-family-maximum-saving-clause with the shipped implementation, and adds four tests and a money case to that entry. All three entries are implemented only in PolicyEngine/microcosm-dynamics. None names a PolicyEngine-US file, and candidates.yaml lists none of them, so no marker or candidate changes here.

The register now has 22 entries (20 before). No entry was removed. No PolicyEngine-US code, parameter or test changes.

Invariants

The guard in policyengine_us/tests/code_health/test_source_conflicts.py checks each of these:

  1. The vendored register's sha256 matches pin.yaml.
  2. Every marker is well formed and names an entry that lists its file as a PolicyEngine-US implementation.
  3. Every cites_entry: true PolicyEngine-US implementation carries its marker. This PR makes this invariant bind on nine files.
  4. The guard counts conflict-sounding comments that carry no marker, and the counts must match KNOWN_UNMARKED. This PR leaves that baseline unchanged.
  5. No id in candidates.yaml is also a register id.

Verification

Changelog

changelog.d/source-conflict-register-cites.changed.md

🤖 Generated with Claude Code

Pin the register to TheAxiomFoundation/rulespec-us@ad03b32,
the merge commit of rulespec-us#1908, which also includes #1907.

- #1908 repins the nine PolicyEngine-US implementations marked in #10441
  to eeaf809 and sets cites_entry: true on each. The guard's
  test_registered_implementations_carry_their_marker now requires those
  nine markers. Removing the niit_magi.py marker makes it fail.
- #1907 adds two Social Security entries,
  oasdi-dual-entitlement-zero-after-age-reduction and
  oasdi-parent-entitlement-count-interval, and gives
  oasdi-family-maximum-saving-clause an implementation, four tests and a
  money case. All three are implemented only in
  microcosm-dynamics, so no PolicyEngine-US marker or candidate changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis
MaxGhenis marked this pull request as ready for review October 25, 2026 08:17
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Hand-off to the US hub, at head 62b0b48.

@MaxGhenis
MaxGhenis merged commit 1961791 into main Oct 25, 2026
39 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

US + core hub merge audit, us#10445 at 62b0b48f6c6e329773416868807b4765818be57c (squash): Vendor the source-conflict register at rulespec-us ad03b325.

  • Review: GPT-6.1 Sol (gpt-6.1-sol served), APPROVE_WITH_NITS at 62b0b48 (Subfleet job 20261024-161917-pe-us-10445-r1, ~/reviews/us-hub/source-conflicts/pin-ad03b325/review-r1.md): vendored file byte-identical to rulespec-us ad03b325 (sha256 matches pin.yaml), register diff 20 to 22 entries as described, nine marked files unchanged with markers, three marker mutations caught by the guard (103 passed). Its one P3 (body wording on KNOWN_UNMARKED) was fixed in the body.
  • Gates checked live at merge:
    • gh pr checks exits 0;
    • the latest Pull request run at the head concluded success;
    • MERGEABLE;
    • not a draft;
    • no reviewer's latest review requests changes;
    • the semantic-overlap guard;
    • head pinned.
  • Impact: None: vendors source_conflicts/known-source-conflicts.yaml and pin.yaml and a changelog fragment; no variable, parameter or test changes, so no model output can move.
  • Order: No dependencies; Point the IN-MT source-conflict candidates at their code on main #10351/Point the NM-WY source-conflict candidates at their code on main #10352 touch only candidates.yaml and their changelog fragments (owner's trial merge with main 62454ca: clean, guard 103 passed).
  • Axiom: n/a (vendors the shared register; no rule or model change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant