Repository navigation
Net spouses' self-employment losses in state EITC helper earned income (IL, CO, DC, IN) - #9820
PavelMakarchuk wants to merge 3 commits into
Conversation
The shared state EITC helper and the Indiana decoupled branch used filer_adjusted_earnings, which floors each spouse at zero. The federal eitc uses eitc_earned_income (#8337), which combines both spouses' amounts per Form 1040 EIC Worksheet B. Fixes #9819. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9820 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 1 -3
Lines 76 40 -36
Branches 2 3 +1
=========================================
- Hits 76 40 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hua7450
left a comment
There was a problem hiding this comment.
Reviewed 03e3718. No calculation defect found in the static review: netting both spouses' wages and self-employment earnings before flooring the tax-unit total matches the IRS EIC Worksheet B treatment. I traced the helper's Illinois, Colorado, DC and Indiana callers, including Indiana's separate 2011–2022 calculation.
- Please add the required
axiom:parity declaration to the PR description, following CLAUDE.md's Axiom Parity section. - Optional regression coverage: add a spousal self-employment loss case in the state-credit phase-out range. The new cases primarily exercise phase-in and maximum-credit behavior.
Verification limits: I did not independently run the tests. All 37 check runs on this commit are successful as of October 6, 02:40 UTC. The source audit is partial: IRS and DC material was accessible, but some historical Illinois, Colorado and Indiana primary documents could not be retrieved.
Both sides appended test cases to co_eitc.yaml and il_eitc.yaml; keep both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out range Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks. Merged
The IL, CO, DC and IN tests pass (2,442). I will add the |
PR Review: Net spouses' self-employment losses in state EITC helper earned income (IL, CO, DC, IN)SummaryThe PR switches
Critical (must fix)None. Should address1. Add the The body has no line starting with Recommended line. rulespec-us already encodes the provision being fixed. In
Two optional additions. The IL "as if" bases (age and ITIN routes) are caller-supplied inputs in rulespec, and composing them is already queued in rulespec-us#1699 (IL1; OPEN, Suggestions
Verified correct
Axiom line assessmentThere is no CI statusAll 28 checks pass at Branch statusThe branch is 3 commits ahead of main and 320 behind. Sibling notes:
Verdict: REQUEST_CHANGES |
DTrim99
left a comment
There was a problem hiding this comment.
The fix is correct for IL, CO, DC and IN in all years: a spouse's SE loss nets on joint returns under 32(c)(2) and Worksheet B line 4b. All 8 new expectations hand-check, and the merged tree is clean. One should-address item: there's no axiom line; us:statutes/26/32/c/2 encoded-correct fits (IL composition is already queued in #1699). Two suggestions, including a follow-up for OK, WA and the NY WFTC reform. Full report in the comment above.
Fixes #9819.
Change
calculate_eitc_amount_from_parameters(policyengine_us/tools/state_eitc_helpers.py) now useseitc_earned_incomeinstead offiler_adjusted_earnings. This is the same earned income as the federaleitc_phased_inandeitc_reduction(Fix EITC earned income self-employment netting #8337). It combines both spouses' wages and net self-employment earnings and floors only the total, per Form 1040 EIC Worksheet B.in_eitc(2011–2022) gets the same change.The helper feeds
il_eitc,co_eitc(ITIN and under-25 paths),dc_eitc_with_qualifying_childandin_eitc_eligible. The Washington credit imports other helper functions, not this one.Tests
filer_adjusted_earningsas an input. They now seteitc_earned_incomewith the same value and keep the same outputs.v39):v39Before this change, PE gave 720, 800, 107.10, 300, 2,380, 400 and 360.
Local runs: the IL, CO credit, DC, IN, WA and federal EITC test folders pass (2,218 tests).
Census effect
In the TAXSIM-35 census comparison for IL, CO, DC and IN (2021–2025), 15 household-years change, 12 now match TAXSIM, and none that matched before stop matching. The other 3 are 2021 Illinois households that still differ by the Illinois rebate.
🤖 Generated with Claude Code