Skip to content

fix: pass --no-interaction on to the artisan commands pollora new runs - #1

Merged
ogorzalka merged 1 commit into
mainfrom
fix/forward-no-interaction
Sep 30, 2026
Merged

ogorzalka merged 1 commit into
mainfrom
fix/forward-no-interaction

Conversation

@ogorzalka

Copy link
Copy Markdown
Member

Problem

pollora new app --ddev --no-interaction runs pollora:install itself, with a terminal attached so its prompts work — but never tells it that no interaction was asked for. In a real terminal the install prompts anyway; without one (CI, an agent) it fails:

Starting WordPress installation...
Site title is required
php artisan pollora:install failed.

(With v1.1.1 the same run announced success on a site where WordPress was never installed.)

Change

runArtisan() builds its command line with artisanCommandLine(), which appends --no-interaction when pollora new was given it. Interactive runs are unchanged.

Goes with Pollora/framework#377: pollora:install without prompts now fills missing options with working defaults (title from the directory, admin, generated password shown once) instead of stopping on the first required prompt.

Tests

New dataset test for both cases; the existing runArtisan failure test now sets an input. composer test green (Rector, Pint, PHPStan, 43 tests, type coverage).

@ogorzalka
ogorzalka merged commit a0b1f96 into main Sep 30, 2026
3 checks passed
@ogorzalka
ogorzalka deleted the fix/forward-no-interaction branch September 30, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant