fix: pass --no-interaction on to the artisan commands pollora new runs - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pollora new app --ddev --no-interactionrunspollora:installitself, with a terminal attached so its prompts work — but never tells it that no interaction was asked for. In a real terminal the install prompts anyway; without one (CI, an agent) it fails:(With v1.1.1 the same run announced success on a site where WordPress was never installed.)
Change
runArtisan()builds its command line withartisanCommandLine(), which appends--no-interactionwhenpollora newwas given it. Interactive runs are unchanged.Goes with Pollora/framework#377:
pollora:installwithout prompts now fills missing options with working defaults (title from the directory,admin, generated password shown once) instead of stopping on the first required prompt.Tests
New dataset test for both cases; the existing
runArtisanfailure test now sets an input.composer testgreen (Rector, Pint, PHPStan, 43 tests, type coverage).