Skip to content

test: expect theme-default's hero preview to match the page #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogorzalka merged 1 commit into from
Sep 25, 2026
Merged

test: expect theme-default's hero preview to match the page #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/e2e/specs/blocks.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ type BlockCase = {
attributes?: Record<string, unknown>;
/** Text the block renders on the front end */
text: string;
/** Why the editor preview is known not to match the page yet */
previewGap?: string;
};

const pluginBlocks: BlockCase[] = [
Expand All @@ -31,7 +29,7 @@ const moduleBlocks: BlockCase[] = [{ name: 'e2e-module/module-card', text: 'Modu
const generatedThemeBlocks: BlockCase[] = [{ name: 'default/theme-card', text: 'Theme Card' }];

const themeDefaultBlocks: BlockCase[] = [
{ name: 'default/hero', text: 'Hero', previewGap: 'theme-default ships the placeholder edit.jsx ("Hero – Block Editor")' },
{ name: 'default/hero', text: 'Hero' },
{ name: 'default/call-to-action', attributes: { heading: `Call to action ${runId}` }, text: `Call to action ${runId}` },
];

Expand Down Expand Up @@ -91,8 +89,6 @@ for (const { host, blocks, skip } of blockCases()) {
});

test(`${block.name} previews in the editor what the page shows`, async ({ admin, editor }) => {
test.fail(block.previewGap !== undefined, block.previewGap);

await admin.createNewPost({ title: `E2E preview ${block.name} ${runId}` });
await editor.insertBlock({ name: block.name, attributes: block.attributes });

Expand Down
Loading