Conversation
…ocks chore: point the submodule at documentation's merged main
theme-default v1.4.5 gives hero an edit.jsx that mirrors save.jsx, in place of the scaffold placeholder "Hero – Block Editor". The preview test no longer needs to be marked as a known failure, and previewGap, which only existed for it, goes.
test: expect theme-default's hero preview to match the page
Two fixture themes: e2e-full has a template for every case of the
hierarchy, e2e-index has index.blade.php alone. The spec activates each
in turn, reads the template in the framework's marker and in a
data-e2e-view attribute every fixture template writes, and checks the
status:
- front-page, home, page-{slug}, page-{id}, a custom page template,
page, single, single-{type}, archive-{type}, archive,
taxonomy-{tax}-{term}, taxonomy-{tax}, category-{slug}, tag,
author-{nicename}, date, search, and 404 with a 404 status;
- a Blade view wins over a PHP template of the same name;
- a Route::wp() route and a Laravel route win over the hierarchy (no
marker: the hierarchy never ran);
- with index alone, every case falls back to index, and an unknown URL
answers 404 rather than index.
The content has fixed slugs, since the templates are named after them.
The theme and reading settings the spec changes are recorded before it
changes them and restored by its own teardown, or by the global one if
the run was interrupted.
Replayed on a site: without the 404 view the 404 case fails; with the
marker disabled every case fails.
test: cover the template hierarchy in the browser tests
The e2e-features fixture plugin declares, by attribute, a filter and an action that leave markers, a post type, two REST routes (public, and IsAdmin with a route parameter) and an Ajax action, and enqueues a plain script through the Asset facade. features.spec checks each by the effect a visitor or an editor sees: - the_content is filtered on a published post, wp_footer prints; - the plugin's post type has its REST type, archive and admin menu; - the public route answers anyone, the IsAdmin one refuses a visitor and answers an administrator; - the Ajax action answers a visitor and a logged-in user; - the Asset facade's script runs; every script and stylesheet of the home page loads, none over plain http, no mixed content, no PHP warning; - get_theme_file_uri() gives the active theme's built entry a URL that answers, and the page a visitor gets carries no server path; - the active theme's menu locations and, when its config/login.php asks for it, its login screen. The theme checks read what the active theme declares rather than assuming one. Replayed on a site: with the theme URI fix of v13.32.0-beta.6 undone, the get_theme_file_uri() and server path checks fail.
test: cover the framework's features in the browser tests
…tests WordPress's __() is renamed __wp() by the framework's patch, and pollora/helper-overrider's __() routes a call with a text domain to WordPress and a call with replacements to Laravel. If Laravel reclaims the name, nothing fails: WordPress catalogues just stop resolving. The e2e-features plugin ships a fr_FR catalogue and a REST route that loads it and answers what __() and __wp() return. Replayed on a site: with the WordPress side of the resolver disabled, the string comes back untranslated and the test fails.
E2E_BROWSERS selects the Playwright projects (chromium by default). Pull requests and pushes keep Chromium alone; the nightly schedule and a manual run use all three engines. Measured locally in Firefox: the suite passes but for the the_content check, which fails on pollora-test for a theme defect already fixed in theme-apiary.
Since WordPress 6.5 translations are kept per locale. The route loaded the plugin's catalogue as fr_FR through plugin_locale, which only worked on a site whose language is fr_FR (pollora-test); on the CI site, in en_US, __() found nothing. Measured with the locale forced to en_US: the former loading leaves the string untranslated, this one translates it.
test: translations through __(), and the browser tests in Firefox and WebKit nightly
chore: release v13.32.0-beta.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
developintomainfor v13.32.0-beta.8 (changelog: #333). No change tosrc/since beta.7: this beta ships the browser test suite (#329–#332). Merged with--admin(authorized by the maintainer for this release:mainrequires an approval that the sole author cannot give).