Repository navigation
feat: leave the Laravel queue out of auto until a connection is set for async actions - #429
Merged
Merged
Conversation
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #427: the Laravel queue becomes opt-in for
auto.Why. The skeleton ships
QUEUE_CONNECTION=database. With the queue first inauto(as #427 did, following the design doc), every async action of a default Pollora project went to the database queue and waited for a worker. On hosting without one, handlers never ran, with no error anywhere. A handler that silently never runs is the worst failure mode. The framework already treats the Laravel scheduler as opt-in (wordpress.use_laravel_scheduler), so this is consistent.Now.
autoputs the queue first only whenhooks.async.queue.connection(HOOKS_ASYNC_CONNECTION) names the connection a worker runs. Asyncornullconnection is still skipped.autopicks Action Scheduler, then WP-Cron, which run without any extra process.via('queue'),#[Async(via: 'queue')]andHOOKS_ASYNC_DRIVER=queuestill use the default connection: an explicit choice.config/hooks.phpand the CHANGELOG explain it. The design doc is updated.Tests. The provider test covers "no connection set: wp-cron despite a database default connection", "set: queue", and "set to sync: skipped". The E2E spec uses
via: 'queue'and is unaffected.