Repository navigation
Avoid potential cyclic reference to data in auth policy - #2822
Merged
Merged
Conversation
… it harder to screw up
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 747def7 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
6 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
6 ns/iter (± 0) |
1 ns/iter (± 0) |
6 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7879796 ns/iter (± 36474) |
1564816 ns/iter (± 35303) |
5.04 |
lotr_graph_window_100/num_nodes |
19 ns/iter (± 0) |
5 ns/iter (± 0) |
3.80 |
lotr_graph_window_100_materialise/materialize |
7879690 ns/iter (± 52210) |
1669150 ns/iter (± 10700) |
4.72 |
lotr_graph_window_10/has_node_existing |
139 ns/iter (± 9) |
62 ns/iter (± 11) |
2.24 |
lotr_graph_window_10_materialise/materialize |
3460858 ns/iter (± 15461) |
971980 ns/iter (± 4278) |
3.56 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2350792 ns/iter (± 26680) |
334634 ns/iter (± 1287) |
7.02 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
147 ns/iter (± 12) |
62 ns/iter (± 14) |
2.37 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1526812 ns/iter (± 8851) |
230399 ns/iter (± 2617) |
6.63 |
lotr_graph_window_50_layered/num_edges_temporal |
142846 ns/iter (± 5062) |
70121 ns/iter (± 7586) |
2.04 |
lotr_graph_window_50_layered/has_node_existing |
395 ns/iter (± 22) |
129 ns/iter (± 12) |
3.06 |
lotr_graph_window_50_layered/graph_latest |
85463 ns/iter (± 1483) |
36649 ns/iter (± 916) |
2.33 |
lotr_graph_window_50_layered_materialise/materialize |
30321551 ns/iter (± 167241) |
3488825 ns/iter (± 24948) |
8.69 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
583676 ns/iter (± 5268) |
192686 ns/iter (± 1569) |
3.03 |
lotr_graph_persistent_window_50_layered/has_node_existing |
419 ns/iter (± 359) |
174 ns/iter (± 83) |
2.41 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/graph_latest |
125931 ns/iter (± 2131) |
57549 ns/iter (± 4809) |
2.19 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
50686661 ns/iter (± 682579) |
5298035 ns/iter (± 147912) |
9.57 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor restructuring of
Datain graphql to avoid a cyclic reference when used with the private auth implementation.Why are the changes needed?
auth_policywas inside ofDataInnerbut some auth policies need access to data which then caused a cyclic reference, causing data to never be droppedDoes this PR introduce any user-facing change? If yes is this documented?
no, just internal changes
How was this patch tested?
tests
Are there any further changes required?
no
Security implications if any