Repository navigation
refactor(integration): name a variant's framework under match - #535
Draft
edwinyjlim wants to merge 1 commit into
Draft
edwinyjlim wants to merge 1 commit into
edwinyjlim wants to merge 1 commit into
Conversation
A variant says which projects it serves in one place, `match`. The build makes the `framework:<id>` menu tag, the menu's `framework` field and a pack's `variant.json` from it, and refuses a `framework` key beside it or a `match` that names no framework. A group that borrows variants takes the framework each one matches and no other match key. The built skills, menu and manifest are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
A variant says which projects it serves in one place:
match.match: { framework: … }. This covers the 38 routable rows of the variant table incontext/skills/integration/config.yaml, and the variants ofai-observabilityand of the twointegration-v2step skills that list their own rows.framework:<id>menu tag, the menu'sframeworkfield and a pack'svariant.jsonfrommatch.frameworkkey of its own fails the build, and so does amatchthat names no framework.react-viteandphpserve no detected framework, so they have nomatch.defaultstays its own key. It marks the pack a framework's projects take when no other row is picked.ai-observabilityusesframeworkfor an LLM provider, such asopenai. That value keeps publishing as theframework:openaitag it publishes today.Verification
npm test: 454 tests pass.main, both from a clean checkout: every published file by content, every zip by its entries and their bytes, and both JSON files structurally. Nothing differs. The 302 skill zips, the 5 group JSON files, the prompts, the menu, the manifest, the MCP archive and the marketplace tree are the same.Rollout
This waits on nothing. It changes no published file, so it needs no release of its own.
🤖 Generated with Claude Code