Repository navigation
feat(emails): send a message category with emails.send #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Silthus
wants to merge
11
commits into
main
Choose a base branch
from
feat/emails-send-category
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+218
−24
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5401139
feat(emails): send a message category with emails.send
Silthus fad7d4f
docs(emails): say where a marketing send needs its unsubscribe link
Silthus 65a1bec
feat(emails): define the message category in code, on code sends only
Silthus 6bdd5bd
test(emails): give the marketing category send its unsubscribe link
Silthus b262082
test(emails): prove category upserts against a fake of the send endpoint
Silthus 66d0a74
test(emails): have the send fake refuse a category value it doesn't know
Silthus 8d0930b
test(emails): assert what the caller gets after each retry case
Silthus 0434df8
test(emails): prove transactional is refused on a template in a category
Silthus 8c3d803
test(emails): assert only what the caller gets in the retry table
Silthus cb57192
fix(emails): document that a send only creates its message category
Silthus 8f29409
fix(emails): document that a template made in PostHog is transactional
Silthus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "posthog-ruby": minor | ||
| --- | ||
|
|
||
| `emails.send` takes a `category` on sends with `template_key`: `PostHog::Emails::TRANSACTIONAL` for transactional email with no category, or a `PostHog::Emails::MessageCategory` with a `key`, `type` (`marketing` or `transactional`), `name` and optional `description`. Leave it out for transactional email with no category, as before, or for the category of the template that `template_key` names. PostHog refuses `TRANSACTIONAL` on a template in a category with `category_mismatch`. A template made in PostHog is transactional: PostHog refuses a send whose `template_key` names a template in a marketing category with `marketing_template`. PostHog creates the category the first time a send names its key, and uses its `name` and `description` only then; change them later in PostHog. A marketing email skips recipients who opted out and needs an `{{ unsubscribe_url }}` link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.