Repository navigation
Conversation
The signup user read already ends at its deadline: the abort cancels the in-flight request, and a cancelled request is not transient, so the retries stop. The extra signal plumbing only cut a backoff of at most 1.5 s short and threw the earlier failure instead of the cancel, for a caller that swallows both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
The read now stops when the backoff that outlasts the deadline ends, with no third request, instead of throwing the earlier 503 at the deadline. Keep the only test of that case rather than deleting it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
marked this pull request as ready for review
November 14, 2026 11:24
|
✅ Security review complete — No findings above the confidence threshold, in 3 min. Add the |
Contributor
Author
End-of-run report: #1562Still yoursNone. Merged under the narrow grantNone. Decisions
Proofs
Side fixes startedNone. |
Silthus
marked this pull request as draft
November 14, 2026 17:47
…-abort Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silthus
marked this pull request as ready for review
November 17, 2026 04:46
|
✅ Security review complete — No findings above the confidence threshold, in 3 min. Add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up trim of #1506, which went through several review rounds. One of them taught
retryTransientto watch an abort signal during its backoff, for the signup user read's 10 s deadline. The read already ends at that deadline without it:fetchUserDatapasses the signal to axios, the abort cancels the in-flight request, andisTransienttreats a cancelled request as final, so the retries stop. The extra plumbing only cut a backoff of at most 1.5 s short and threw the earlier failure instead of the cancel, for the one caller (readSignedUpUser) that swallows both.Changes
Deletion only.
src/shared/api.ts:retryTransientloses itssignalparameter, the abort-aware sleep, and the twosignal?.abortedchecks. Its default sleep goes back to the plain timer it had before feat(analytics): report detected email providers and identify signup runs #1506.fetchUserDatakeeps itssignaland still passes it to axios.src/shared/__tests__/api-errors.test.ts: keeps the one test of a deadline that passes during a backoff, now named "stops after a backoff that outlasts the deadline, without another request". It now expects the read to reject once that backoff ends, still with two requests, instead of the earlier 503 at the deadline.Kept from #1506, each with its reason:
readSignedUpUser,analytics.identifyUser): shipped in v2.94.0 and runs on every--signup.$identifyand$create_aliashave already merged persons for real signups, so removing it would change product analytics going forward. It is not unused./api/users/@me/read would hang signup with no limit, since axios sets no default timeout.ERR_CANCELEDas not transient: this is what now ends the retries at the deadline.signup.test.ts: they cover the deadline that a signup run can observe.email-providers.ts,report.tsand its test): this is the core ask of feat(analytics): report detected email providers and identify signup runs #1506.Note
🔵 Merge risk: low · two-way door
wizard --signupwhose user read hits its 10 s deadline during a retry backoff now waits out that backoff (at most 1.5 s more). It then fails with the cancel instead of the earlier 5xx.readSignedUpUserswallows either and signs in unidentified, as before.fetchProjectData, API-key login, OAuth user read). None of them passes a signal. Their backoff sleeps on a plain timer again, as before feat(analytics): report detected email providers and identify signup runs #1506, and sleeps the same 500 and 1500 ms. The kept test "gives up after one deadline, retries included" runs that real backoff and the retry after it. TheretryTransienttests cover which failures retry.fetchUserDatareports for a signup read past its deadline during a backoff now carriesnetwork_code: ERR_CANCELEDrather than the 5xxstatus_code.Test plan
Lane gate on this branch:
node scripts/generate-version.cjs && pnpm typecheckexit 0,pnpm lintexit 0 (warnings only, as on main),pnpm vitest run src/shared src/tui/authpasses, andapi-errors.test.tspasses at the final head. A run offetchUserDataagainst a local stub (503, then a 503 after 2 s, 3 s deadline) on main and on this branch shows the delta in the callout: main rejects with the 503 at about 3.0 s, this branch rejects with the cancel at about 4.0 s, and both send two requests. Fullpnpm testis covered by CI. Locally, unrelated tests timed out at 5 s under machine load, and a different set failed on each run.🤖 Generated with Claude Code
How did you test this code?
073ad93(reused from649ad17)073ad93(reused from649ad17)649ad17073ad93Not checked: none recorded
Full receipt (PostHog team): https://artifacts.posthog.com/a/xoxeTaonlWLNIs1IiCpSbO