Repository navigation
feat(orchestrator): read the step skills by name and complete them from the pack - #1566
Draft
edwinyjlim wants to merge 3 commits into
Draft
edwinyjlim wants to merge 3 commits into
edwinyjlim wants to merge 3 commits into
Conversation
…om the pack The bundled prompts name the integration-* step skills. A skill whose menu entry has frameworkReferences is installed once a run and completed from the framework's pack. When it cannot be completed, the tasks that name it fail as they do when a skill fails to install, and a run that installed no pack fails before any task starts. The wizard-agent-dag-skills flag, the replaces mapping and the fallback to a replaced skill are removed. A context-mill pin older than 1.66.0 is refused, since that is the first release that publishes these skills. The skill menu and the step and pack pair are recorded from context-mill 1.66.0, and record:context-mill-fixtures records the pair. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
install_skill completes a skill whose menu entry has frameworkReferences from the framework's pack, through the installer the orchestrator uses, with the same path and scan checks. The pack is picked with the run's match keys and read from a scratch folder. A run with no framework gets an error that says so, and nothing is installed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A linear error tracking run installs integration-install and integration-init when PostHog is not integrated yet. install_skill completes both from the framework's pack. Comments describe the step skills and the bundled prompts as they are. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour
A task reads the step skills by their own names, and a step skill written once for every framework is always completed from the framework's pack.
integration-*step skills, such asintegration-installandintegration-session-replay.frameworkReferencesis installed once a run into an emptied folder, completed from the framework's pack, and its rewrittenSKILL.mdis scanned.orchestrator repackaged skill unavailableonce, with the skill, the reason and the framework.install_skillcompletes such a skill the same way, in both sequences and both harnesses, through the same installer. It picks the pack with the run's match keys and reads it from a scratch folder. A run with no framework gets an error that says so, and nothing is installed.--context-mill-versionrefuses a release older than 1.66.0, the first that publishes these skills. The message names that release.The
wizard-agent-dag-skillsflag, thereplacesmapping, the fallback to a replaced skill, theorchestrator_skillstag andpnpm verify:repackaged-skillsare gone.Fixtures
The skill menu and the step and pack pair are recorded from context-mill 1.66.0.
pnpm record:context-mill-fixturesnow records the pair too: the step skill as published, the pack files that completing it reads, and the completed skill. The recorded completed skill differs from the skill context-mill 1.66.0 publishes for the same step and framework in one line, thenamein its frontmatter.Verified
pnpm typecheckandpnpm lint(0 errors).pnpm test: 292 files, 4,450 tests pass, 1 skipped.repackaged-skills.test.tsandrepackaged-skill-installer.test.tscover each way a completion fails: a failed install, a pack that cannot complete the skill, a scan that rejects or fails, a link on the way, and a run with no pack.tool-skill-install.test.tscoversinstall_skill: a plain skill, a completed one, a run with no framework, and a rejected scan. The pack it reads is gone from disk afterwards.context-mill-version.test.tscovers the floor.Changes in behaviour to know about
integration-installandintegration-init, from the menu'sintegration/installandintegration/initcategories.install_skillcompletes both from the framework's pack.install_skilltakes an exact menu id, as before. A name that is a skill family, such asintegration-v2-install, is not found.FEATURE_FLAGS_UNSUPPORTEDstill stops feature flags on Kotlin Multiplatform.Rollout
This is the second of four stacked PRs that remove the old code paths. They merge together and ship in one release.
wizard-agent-dagandwizard-agent-dag-skillshave both held at 100% with no stop rule tripped, no run that fetched its prompts, and no run that fell back to an old skill.🤖 Generated with Claude Code