Repository navigation
refactor(skills): pick skills by family, tags and traits alone - #1567
Draft
edwinyjlim wants to merge 2 commits into
Draft
edwinyjlim wants to merge 2 commits into
edwinyjlim wants to merge 2 commits into
Conversation
A menu entry's family is the key of the category the menu lists it under, with / as -. resolveSkill matches a family on that and reads framework and default from tags only. The group, framework and default fields are no longer read. A run's match keys are the project's traits, with no override from the run's input. install_skill and the spell book resolve a name through resolveSkill, and the spell book reads a flow's families from the derived family. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour
Every skill is picked the same way: by its family, its tags and the project's traits.
/as-. An entry underintegration/installis in the familyintegration-install, and the 40 framework packs underintegrationare the familyintegration. The fetch sets it on every entry, andresolveSkillmatches a family on it.resolveSkillreads the framework and the default from an entry's tags,framework:<id>anddefault. Thegroup,frameworkanddefaultfields of a menu entry are no longer read.frameworktrait resolves no family, so it has no framework pack.install_skillresolves the name it is given throughresolveSkill, so it accepts a menu id or a family. The spell book resolves a program's own skill and the framework's pack throughresolveSkilltoo. With no framework it still hands over every skill whose family is the flow's name or is prefixed by it.A bundle entry is still expanded into its variants and installed as before.
Verified
pnpm typecheckandpnpm lint(0 errors).pnpm test: 292 files, 4,450 tests pass, 1 skipped.group, and everyframeworkordefaultfield has its tag: 502 entries, 200 of them bundle variants, with no exception. For every skill name and framework, the pick is the same as before: 38,544 comparisons, no difference.Changes in behaviour to know about
install_skillnow resolves a family.install_skill('integration')installs the framework's pack, and a family of bundle variants resolves to the variant for the run's framework.wizard skill <family>on a project with no framework.Rollout
This is the third of four stacked PRs that remove the old code paths. They merge together and ship in one release.
wizard-agent-dagandwizard-agent-dag-skillshave both held at 100% with no stop rule tripped, no run that fetched its prompts, and no run that fell back to an old skill.group,frameworkordefaultfield, so context-mill can stop publishing them once older wizard versions have drained.🤖 Generated with Claude Code