Repository navigation
refactor(skills): stop reading bundle entries from the skill menu - #1568
Draft
edwinyjlim wants to merge 1 commit into
Draft
edwinyjlim wants to merge 1 commit into
edwinyjlim wants to merge 1 commit into
Conversation
A menu entry that is a bundle of variants is left out when the menu is fetched, so it is never offered or installed. The bundle installer, the bundle fields on a menu entry and the expansion of a bundle's variants are removed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour
The wizard installs a skill from its own zip, and from nothing else.
load_skill_menu, resolved, or installed.The bundle installer, the
bundleandvariantsfields on a menu entry, and the expansion of a bundle's variants are gone.Verified
pnpm typecheckandpnpm lint(0 errors).pnpm test: 292 files, 4,443 tests pass, 1 skipped.skill-menu.test.tscovers a menu with a bundle entry: the entry is left out and its neighbour is kept.flow-graphs.test.tsstill finds every skill the bundled prompts name on the recorded context-mill 1.66.0 menu, with its five bundle entries left out.error-trackingmenu category and installed the skill they chose from it.Rollout
This is the last of four stacked PRs that remove the old code paths. They merge together and ship in one release.
wizard-agent-dagandwizard-agent-dag-skillshave both held at 100% with no stop rule tripped, no run that fetched its prompts, and no run that fell back to an old skill.context-mill publishes bundle entries until it releases without the old step skills. Until then, a wizard with this change does not do three things:
integration-v2-install, throughinstall_skill. Onmainthat name is already not foundintegration-v2/*andreplay-vision-enable-replaymenu categories. No bundled prompt names oneNo orchestrator flow reaches a bundle: every skill its prompts name is published as its own zip.
🤖 Generated with Claude Code