feat(visual): VisualTestsSuite data-driven + masques + options navigateur - #67
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…lpers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PrestaEdit
force-pushed
the
feat/visual-suite
branch
from
September 28, 2026 13:00
9976674 to
e79c975
Compare
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Socle lib pour les suites visuelles éditables depuis l'app (spec :
app/docs/superpowers/specs/2026-09-28-visual-suite-editor-design.md).TestsSuite::useBrowserOptions()/browserOptions()/resetBrowser(): taille de fenêtre + UA par combinaison, fermeture propre du navigateur partagé (y compris orphelin via socket). Fix des défautsWINDOW_SIZE_*inversés.CommonPage::visualCheckpoint(..., array $masks = []): masquage par sélecteur (une règle CSS par sélecteur, retrait garanti enfinally), + helpersscrollBelow()etwaitForStable()(best-effort, lazy images sous le pli ignorées).VisualDevices(presets desktop/tablet/mobile) +VisualTestsSuite: suite pilotée par$devices/$locales/$checkpointslittéraux ; une exécution = une combinaison (globalsDEVICE/LOCALEou envPRESTAFLOW_DEVICE/PRESTAFLOW_LOCALEen CLI). Checkpoints exclus ou langue sautée →skip.Tests
vendor/bin/phpunit→ OK (357 tests, 823 assertions), +25 tests.Limite connue
getBrowser()réutilise tout socket vivant sans comparer les options : en CLI, un navigateur laissé ouvert par un autre process à une autre taille peut être réutilisé. L'app appelleresetBrowser()avant chaque combinaison.🤖 Generated with Claude Code