Repository navigation
Audit fixes: crash-safe elevated changes, MainWindow split, README gallery - #23
Merged
Merged
Conversation
The main ruleset requires an approving review, so auto-merge never completed; Dependabot PRs are merged by hand. The Wi-Fi plan is implemented and its decisions live in ADR 0001.
Snapshots never leave the process that created them (the audit store keeps its own record), so the HMAC authenticated nothing. Rollback still refuses a snapshot whose apply did not succeed.
The tuning plan caught only some exceptions from the worker: a worker that died without answering raised InvalidDataException out of an async void handler and closed the app. DNS, interrupt affinity and the tuning plan now share ElevatedChange, which turns every failure into a status line, and the app logs and reports any exception a handler still misses.
Preferences are now saved read-modify-write, so a view that owns a field cannot overwrite the fields MainWindow or another view saved meanwhile.
Also drops _lastLoadedLatency, which was written but never read.
The monitor now shows an inventory it had to capture itself, so every view receives the same adapters.
Neither TabControl template named its ContentPresenter PART_SelectedContentHost, so TabItem's automation peer exposed no page content at all: screen readers and UI Automation saw only the navigation. The Preferences combo boxes also saved their initial selection, which recorded the Windows language as a user choice and stopped SockTuner following Windows afterwards.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElevatedChange) that turns failures into a status line; a worker dying without answering used to close the app from the tuning plan. The app now also logs and reports any exception a handler misses.PART_SelectedContentHost), and the first start pinned the Windows language as a user choice.