Repository navigation
Fix the mouse polling test: read only the raw input header - #19
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
GetRawInputData was called with RID_INPUT and a buffer sized for the header alone; a mouse RAWINPUT is 48 bytes, so every call failed and the test always reported too little movement. RID_HEADER reads the 24-byte header it needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mouse polling test in Devices & latency → USB and input always ended with "Not enough movement was captured".
GetRawInputDatawas called withRID_INPUTand a buffer the size ofRAWINPUTHEADER(24 bytes on x64). A mouseRAWINPUTis 48 bytes, so every call returned -1 and no sample was recorded.RID_HEADERreads only the header, which is all the test needs (type and device handle).Checked with a standalone probe that registers raw input and injects 20 mouse moves:
RID_INPUTfailed on 27/27 messages,RID_HEADERsucceeded on 27/27.Build OK, 247/247 tests.