Skip to content

Four 32412 - #8946

Open
henryjonathanquispe wants to merge 79 commits into
VITE_INBOXfrom
FOUR-32412
Open

Four 32412#8946
henryjonathanquispe wants to merge 79 commits into
VITE_INBOXfrom
FOUR-32412

Conversation

@henryjonathanquispe

@henryjonathanquispe henryjonathanquispe commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Describe the issue this ticket solves and describe how to reproduce the issue (please attach any fixtures used to reproduce the issue).

Solution

  • List the changes you've introduced to solve the issue.

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:package-data-sources:VITE_INBOX
ci:package-variable-finder:VITE_INBOX

@henryjonathanquispe
henryjonathanquispe changed the base branch from VITE_INBOX to develop July 28, 2026 21:20
@gitguardian

gitguardian Bot commented Jul 28, 2026

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@henryjonathanquispe
henryjonathanquispe changed the base branch from develop to VITE_INBOX July 28, 2026 21:20
@henryjonathanquispe
henryjonathanquispe force-pushed the VITE_INBOX branch 3 times, most recently from 29fc119 to cac46ac Compare July 29, 2026 18:16
@cursor

cursor Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Broad frontend build and boot-order changes across modeler, screen builder, tasks, and admin OAuth/settings; regressions are likely on package addon timing and ESM/global compatibility rather than server-side security.

Overview
This PR continues the Laravel Mix → Vite migration across many authenticated and auth-related pages, using layouts.layoutnextvite (and new mobilenextvite / previewnextvite where needed) instead of Mix script tags.

Bootstrapping: Blade now seeds window.temporal (and often window.packages) before Vite loaders; page modules read that data instead of relying on inline const globals. Shared entrypoints loaderMinimal.js / loaderMonaco.js call setupMain(), copy package lists onto ProcessMaker, and setupMain dispatches app-bootstrapped. Heavy pages (modeler, screen builder, cases, requests) get dedicated loaders that wire ScreenBuilder, Monaco, and modeler globals; Vue roots often mount on window load so deferred package Mix scripts run first.

JS refactors: Inline Vue in Blades moves into ESM entry files (admin users/groups/auth-clients, categories, signals, screens edit, processes list, etc.). SharedComponents barrel imports become explicit relative .vue paths. Webpack require() for images/CSS becomes public paths or Vite ?raw imports (TinyMCE skins in Customize UI). jQuery is exposed as a callable window.$. Catalogue template events use ProcessMaker.EventBus instead of a local EventBus.

Backend: Screen builder and request preview pass an uppercased type into views for screen rendering.

Docs: resources/js/vite/AGENTS.md is expanded with migration status, script order, and pitfalls (Blade/Vue bindings, iframe preview, logs router).

Auth: Password change and some 2FA/minimal layouts use @vite for app.scss and a new vite/auth/auth.js bootstrap instead of the full Mix vendor stack.

Reviewed by Cursor Bugbot for commit 927dcea. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8f18ccd. Configure here.

Comment thread resources/views/layouts/previewnextvite.blade.php
Comment thread resources/jscomposition/cases/casesDetail/loaderCasesDetail.js
Comment thread resources/js/processes/screens/edit.js
@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant