You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Octane, the navigation menu keeps state between requests. A user can see Admin/Designer options from a previous session, even without permissions. The menu can also repeat items on each page load.
Repro:
Log in as superadmin → open /inbox or /tasks
Log out
Log in as SSO user (no admin permissions)
Bug: Admin/Designer still appear in the topnav (or menu items duplicate)
Solution
Removed MenuManager from Octane warm
Added MenuManager::reset() to clear menu builders between requests
ResetRequestState now resets the menu at the end of each request
Unit test added for menu leak
How to Test
Restart Octane
Login superadmin → load /inbox → logout
Login SSO user (no admin perms)
Confirm Admin/Designer are hidden and menu is not duplicated
Medium Risk
Touches per-request Octane lifecycle and navigation visibility; wrong reset timing could affect menu rendering, but scope is isolated to menu state cleanup.
Overview
Fixes Octane menu state leaking between requests so a later user (e.g. SSO without admin rights) no longer sees Admin/Designer entries or duplicated items from a prior superadmin session.
Adds MenuManager::reset() to clear internal menu builders and collections, and invokes it from ResetRequestState on each request teardown (alongside existing redirect/timing resets). MenuManager (and ScreenBuilderManager) are removed from Octane’s warm list so workers do not keep a long-lived menu instance that accumulates per-user items.
A unit test simulates admin menu generation, runs the Octane reset, then generates menus for a non-admin and asserts admin nav items are absent.
Reviewed by Cursor Bugbot for commit c9a7fc1. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
On Octane, the navigation menu keeps state between requests. A user can see Admin/Designer options from a previous session, even without permissions. The menu can also repeat items on each page load.
Repro:
Solution
Removed MenuManager from Octane warm
How to Test
Related Tickets & Packages
Code Review Checklist