Skip to content

fix(FOUR-33169): Error message is displayed when the page is loading - #9062

Open
rodriquelca wants to merge 1 commit into
developfrom
bugfix/FOUR-33169
Open

rodriquelca wants to merge 1 commit into
developfrom
bugfix/FOUR-33169

Conversation

@rodriquelca

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Error message is displayed when the page is loading on the Change Password page.

Reproduction Steps:

  1. Navigate to the Change Password page (/password/change)
  2. Observe that the error message area renders during the initial page load
  3. The v-for loop over errors.password executes even when errors.password is null, causing the error message to be displayed while the page is loading

Solution

Updated resources/views/auth/passwords/change.blade.php to wrap the error message loop in a <template v-if="errors.password"> condition, so errors are only rendered when they actually exist:

<template v-if="errors.password">
  <small v-for="(error, index) in errors.password" :key="index" v-cloak class="text-danger d-block">
    @{{ error }}
  </small>
</template>
error_change_pass.mov

How to Test

  1. Navigate to the Change Password page (/password/change)
  2. Verify no error message is displayed during the initial page load
  3. Submit the form with mismatched passwords
  4. Verify the "Passwords must match" message appears correctly
  5. Submit with invalid data and verify server-side validation errors are displayed correctly

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Blade/Vue template-only change on the change-password form; no auth or API logic modified.

Overview
Fixes a flash of password validation errors on the Change Password page (/password/change) during initial load.

The v-for over errors.password used to run while errors.password was still null in Vue’s initial state, so the error block appeared briefly before hydration. The loop is now wrapped in <template v-if="errors.password">, and each item gets a :key="index". Validation behavior after submit (client “Passwords must match” and server errors) is unchanged.

Reviewed by Cursor Bugbot for commit f76e81e. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants