You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Error message is displayed when the page is loading on the Change Password page.
Reproduction Steps:
Navigate to the Change Password page (/password/change)
Observe that the error message area renders during the initial page load
The v-for loop over errors.password executes even when errors.password is null, causing the error message to be displayed while the page is loading
Solution
Updated resources/views/auth/passwords/change.blade.php to wrap the error message loop in a <template v-if="errors.password"> condition, so errors are only rendered when they actually exist:
Low Risk
Blade/Vue template-only change on the change-password form; no auth or API logic modified.
Overview
Fixes a flash of password validation errors on the Change Password page (/password/change) during initial load.
The v-for over errors.password used to run while errors.password was still null in Vue’s initial state, so the error block appeared briefly before hydration. The loop is now wrapped in <template v-if="errors.password">, and each item gets a :key="index". Validation behavior after submit (client “Passwords must match” and server errors) is unchanged.
Reviewed by Cursor Bugbot for commit f76e81e. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Error message is displayed when the page is loading on the Change Password page.
Reproduction Steps:
/password/change)v-forloop overerrors.passwordexecutes even whenerrors.passwordisnull, causing the error message to be displayed while the page is loadingSolution
Updated
resources/views/auth/passwords/change.blade.phpto wrap the error message loop in a<template v-if="errors.password">condition, so errors are only rendered when they actually exist:error_change_pass.mov
How to Test
/password/change)Related Tickets & Packages
Code Review Checklist