Skip to content

feat(trailers): bring back in-app trailer playback - #809

Merged
ProdigyV21 merged 3 commits into
ProdigyV21:mainfrom
silentbil:feature/restore-in-app-trailers
Oct 16, 2026
Merged

ProdigyV21 merged 3 commits into
ProdigyV21:mainfrom
silentbil:feature/restore-in-app-trailers

Conversation

@silentbil

@silentbil silentbil commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Brings back ARVIO's in-app trailer player for the smaller trailer surfaces, and keeps YouTube's official player where trailers are shown large. In-app trailers have no YouTube logo, title bar or buttons and start noticeably faster; the official player gives HD.

Which player plays where

  • In-app player: the expanding row card (classic and Netflix-style Home) and the classic Home hero background. On poster (vertical) rows, which have no expanding card, the hero plays the trailer instead. Any D-pad / OK / Back press stops a playing hero trailer on the classic Home.
  • Official YouTube player: the Netflix-style Home billboard and the Details trailer. YouTube only serves 360p to the in-app player, which looks soft on these large surfaces; the official player plays 720p-1080p (measured on the emulator).
  • Details on TV: the trailer now fills the screen. The bottom strip is gone; YouTube's own controls stay reachable (Up), OK pauses, Left/Right seek 10 s, Back closes and returns focus to the Trailer button. Mobile is unchanged.

Faster start

  • As soon as Home knows a title's trailer key, it looks up the trailer's stream in the background, so in-app trailers usually start right after the focus delay.
  • The trailer-key loading from main (cached and de-duplicated) is kept; the lookup is added to it.
  • Trailer auto-play follows the profile's setting again. The existing trailer settings are unchanged.

Removed

  • OpenYouTubeTrailer and its URL test (no longer used).

Testing

  • Unit tests pass (./gradlew :app:testSideloadDebugUnitTest); the on-device tests compile.
  • Tested on an Android TV emulator (1080p, API 30): billboard trailer in HD with the info on top, in-app row-card trailers, full-screen Details trailer with Back restoring focus, and Back / hold-Back on Home after merging the latest main.
  • Not yet tested: classic Home (Netflix-style Home off) and mobile.

Replace the official YouTube player (WebView) with ARVIO's in-app
trailer player everywhere trailers play:

- Home: the hero background trailer and the expanding row card,
  including the poster-row case, where the hero plays the trailer.
- Netflix Home: the billboard and the focused card.
- Details: the trailer button opens a full-screen in-app player.

The trailer's stream is looked up as soon as its key is known, so it
usually starts right after the focus delay. Trailer auto-play is read
from the profile's setting again.

The official player components, their tests and the
android-youtube-player dependency are removed.
@github-actions github-actions Bot added the area: android Changes to the Android app or Gradle build label Oct 16, 2026
The in-app player only gets 360p from YouTube, which shows on large
surfaces. The Netflix Home billboard and the Details trailer use
YouTube's own player (720p-1080p); row cards keep the in-app player.
On TV the Details trailer now fills the screen.
…app-trailers

# Conflicts:
#	app/src/main/kotlin/com/arflix/tv/ui/screens/home/HomeScreen.kt
@ProdigyV21
ProdigyV21 merged commit 62257ee into ProdigyV21:main Oct 16, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: android Changes to the Android app or Gradle build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants