Repository navigation
fix(home): short, correct descriptions; more of it on Details - #810
Merged
Merged
Conversation
- Home (billboard and focused card) shows the overview's first sentence, like Netflix's short synopsis, so it no longer ends in "...". A very short first sentence takes the next one; abbreviations don't end one; live channels keep the guide text. - Home could show another title's description: when a title's overview looked short, it searched TMDB by name and took the longest overview of any result with that name. It now only accepts the same title. - Details: the overview is wider (66% of the screen, up to 820 dp) and shows up to 4 lines.
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Short descriptions on Home
The Netflix-style Home (billboard and the focused card) now shows the overview's first sentence, like Netflix's short synopsis, so descriptions no longer end in "…".
Home could show another title's description
When a title's overview looked short (under 140 characters), Home searched TMDB by name and took the longest overview among the results, without checking it was the same title. Titles that share a name with an older film or series (e.g. an older adaptation) showed that other title's description on Home, while Details showed the right one. The lookup now only accepts the same TMDB id and type. This also affects the classic Home hero.
More description on Details
The Details overview was a fixed 420 dp wide with 3 lines. It is now 66% of the screen width (420–820 dp) with up to 4 lines, so most overviews show in full.
Testing