fix: avoid deprecated FIDO2 capability query - #26
Open
UglyEgg wants to merge 1 commit into
Open
Conversation
ProtonVPNAPI.supports_fido2 calls its deprecated is_fido2_lib_available compatibility property, which emits a warning during a normal capability check. Read both capability values from the current session instead. Preserve the existing truth table and keep the deprecated public property available for external callers. Cover all four library/key combinations and fail the regression test if the deprecated property is consulted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ProtonVPNAPI.supports_fido2calls the deprecatedis_fido2_lib_availablecompatibility property. A normal capability check therefore emits a deprecation warning from inside API Core itself.Change
Read
fido2_lib_availableandsupports_fido2from the same current session. The deprecated public property remains available for external callers.Verification
supports_fido2consults the deprecated property.No networking, authentication flow, or public API behavior changes.
Development disclosure: I developed this patch with material assistance from OpenAI Codex under my direction, then reviewed, tested, and signed the final change.