docs: fix the claims that contradict the code - #39
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Security review: nothing to raise. Read the documentation and landing content changes. |
commit: |
8c45e62 to
9ab80cd
Compare
|
Deployment failed for project vecstore-sdk with the following error: Learn More: https://vercel.com/pungrumpy?upgradeToPro=build-rate-limit |
Background
An audit of the docs against the code found claims that the code does not back up.
Resultand can refuse a filter.fetch, which needs ids the SDK cannot list.topK.upsertrejects that metadata.RedisClientLikehas seven calls, not eight, and "the other three adapters" on the Upstash page should be six.docs/releasing.mddid not list theVERCEL_DEPLOY_HOOKsecret the release job needs.Stacked on #38. No code changes, so there is no changeset.
The landing highlights, captured on production and on this PR's Vercel preview at 1440px wide:
Summary
nodejs_compat, because the adapter importsnode:crypto. The query-then-delete recipe now loops until a query returns nothing.upsertand the verbs enforce, and the batch sizes they use.store.raw.Verification
bun run checkexits 0.cd apps/web && bun run typecheckexits 0.bun run testinpackages/vecstore-sdkshows 398 pass, 0 fail.RedisClientLikehas seven calls.listVectorsexists incloudflare7.1.Checklist
vecstore-sdk(runbun run changesetin the project root). Not needed, because nothing underpackages/*/srcor a manifest changes.