Skip to content

configgen: remove dead input_exit_emulator_btn write #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pyohwan merged 1 commit into from
Sep 12, 2026
Merged

configgen: remove dead input_exit_emulator_btn write #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions ...ra/core/batocera-configgen/configgen/configgen/generators/libretro/libretroControllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,6 @@ def cleanControllerConfig(retroconfig: UnixSettings, controllers: Controllers, /
def writeHotKeyConfig(retroconfig: UnixSettings, controllers: Controllers, /) -> None:
if controllers and 'hotkey' in controllers[0].inputs and controllers[0].inputs['hotkey'].type == 'button':
retroconfig.save('input_enable_hotkey_btn', controllers[0].inputs['hotkey'].id)
# Without this, input_enable_hotkey_btn alone arms the hotkey
# modifier but no joypad action is bound to it, so Hotkey+Start
# (the batocera keyboard convention for force-quitting a game, see
# es_input.cfg's keyboard hotkey=select binding) does nothing on a
# gamepad - only the keyboard input_exit_emulator="escape" above
# ever quits a running libretro core. Confirmed live on hardware
# (ODROID-M1, SHAKS S6b pad): Hotkey+Start did not exit FBNeo
# until this was added.
#
# Nested inside the hotkey check (not a second top-level if): if a
# pad has no hotkey button mapped, RetroArch treats a lone
# input_exit_emulator_btn as unmodified - Start alone would quit
# mid-game on every such pad, on every board, the moment
# controllers are configured at all.
if 'start' in controllers[0].inputs and controllers[0].inputs['start'].type == 'button':
retroconfig.save('input_exit_emulator_btn', controllers[0].inputs['start'].id)

# Write a configuration for a specified controller
def writeControllerConfig(
Expand Down
Loading