Skip to content

Extra fixes - #6

Merged
cmvcordova merged 27 commits into
QLS-MiCM:mainfrom
NajiaB:fixes
Oct 29, 2026
Merged

cmvcordova merged 27 commits into
QLS-MiCM:mainfrom
NajiaB:fixes

Conversation

@NajiaB

@NajiaB NajiaB commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Extra fixes following @cmvcordova 's comments.

  • Notebooks 04 and 05 (solutions + workbooks): the ColumnTransformer now uses all 6 CVD features. num_features = ["age", "chol", "bp", "bmi"], cat_features = ["smoker", "sex_male"]
  • Notebook 05 (solutions + workbooks): grid search now includes "activation": ["identity", "relu", "tanh"].
  • Notebook 02 solution: added the missing import matplotlib.pyplot as plt. This fixes the plt NameError and the X_train NameErrors, since the train/test split now runs.
  • All 7 Colab workbooks now load data from QLS-MiCM/SupervisedML
  • fixed typos
  • removed ipynb_checkpoints.

About the duration:

  • the README says 2 hours. It is intended.

@github-actions

Copy link
Copy Markdown

PR Checklist

PR: #6
Author: @NajiaB

Please confirm the following before requesting review:

  • You have read the workshop contribution guidelines
  • You have included a README outlining the workshop and its contents
  • You have included requirements and setup instructions in the README.md
  • You have tested the workshop exercises and data sets
  • You have organized your repo to match the workshop template structure
  • You have included a pdf copy of your slides to facilitate review
  • All changes or contributions are clearly explained in the PR description

Reply to this comment or check off the boxes when complete.

@cmvcordova

cmvcordova commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Thanks @NajiaB, this covers most of #5. Remaining items:

  1. Notebook 02 solution still fails with NameError: X_train. Correction: you are right, the split is at the end of the plotting cell. The plt crash stopped it from running, so your import fixes both errors. Sorry for the noise.
  2. Typos. The notebook 05 solution has "GridSewarchCV", and the workbook has "Use use".
  3. Please delete README_template.md.
  4. Question about workbook 05. It still uses 3 features and only the identity activation. Is that meant as the starting point for students? If not, please apply the same change as the solution.

Once these are fixed, I will rerun all the notebooks and approve.

@cmvcordova cmvcordova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NajiaB! I ran all 14 notebooks on this branch and the solutions run cleanly. All items from #5 are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants