Skip to content

Fix missing ellipses when reporter limits are one - #834

Open
VinisHub wants to merge 2 commits into
QuEST-Kit:develfrom
VinisHub:fix/reporter-ellipsis-810
Open

VinisHub wants to merge 2 commits into
QuEST-Kit:develfrom
VinisHub:fix/reporter-ellipsis-810

Conversation

@VinisHub

@VinisHub VinisHub commented Oct 13, 2026 •

Copy link
Copy Markdown

Fixes #810

What changed

  • Show … when columns are omitted, including when the display limit leaves no right-hand section to print.
  • Show ⋮ when rows are omitted, including when the display limit leaves no lower section to print.
  • Add a regression test using the CompMatr1 example from the issue.

How it was tested

  • All 14 debug test cases passed in CPU serial mode and with 2 and 4 MPI ranks.
  • CUDA compilation passed.
  • Compared 512 reporter cases in serial mode and another 512 with 2 MPI ranks against upstream/devel. Differences were limited to the intended ellipsis additions and conditional spacing before row labels.
  • Confirmed the regression checks fail against upstream/devel and pass with this fix.
  • Verified that stdout and reporting defaults are restored after a reporting exception.
  • git diff --check passed.

GPU execution and Windows/MSVC were not tested locally.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 19:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@VinisHub

Copy link
Copy Markdown
Author

Hi, I’ve updated the fix and regression tests in commit 1c0c3fd. The debug tests pass locally in serial mode and with 2 and 4 MPI ranks, and CUDA compilation passes. The latest workflows are awaiting approval—could a maintainer please approve them? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants