Repository navigation
Fix cargo audit: bump quinn-proto, rustls, self_update; ignore lockfile-only ruzstd - #185
Conversation
…le-only ruzstd quinn-proto 0.11.19 (RUSTSEC-2026-0338..0342), rustls 0.23.46 (RUSTSEC-2026-0346..0349), self_update 1.3.1 for zip 9 (RUSTSEC-2026-0367..0369). RUSTSEC-2026-0344 (ruzstd) is ignored: it is reached only through the unused subxt-lightclient/smoldot optional dependency, which pins ruzstd ^0.8. Co-authored-by: Cursor <cursoragent@cursor.com>
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT-6.1 Sol
APPROVE — no blocking findings at 56062f58209d14ba4a8c82841bd82a0ade94d821 (base 413a6e23f7fc9ebbe8145d9cd887cd52a70cc933).
The dependency updates resolve the reported audit failures without changing the application API. The exception for RUSTSEC-2026-0344 is justified for the current feature set: cargo tree --locked --target all --all-features -e all -i smoldot and the equivalent ruzstd query both show no active dependency path. I also checked the shared updater configuration and its use by the update notification path.
Validation:
SKIP_CIRCUIT_BUILD=1 cargo test --locked --lib cli::update::tests -- --nocapture: 4 passed; circuit generation skipped.cargo-audit0.22.1 with a freshly fetched advisory database: 0 unignored vulnerabilities; the 8 existing warnings remain. The configured ignore list contains only RUSTSEC-2026-0344.- Locked dependency resolution, changed TOML formatting, pinned-nightly Rust formatting, and
git diff --check: passed. The worktree's tracked files remain unchanged.
CI at review time: Format and Security Audit passed; Linux/macOS builds and tests, Clippy/docs, and examples are still running. Both dependency-cooldown checks failed because the patched releases are younger than the required 30 days. Resolve that merge gate through the documented emergency bypass process or the cooldown period, and require the remaining CI checks to finish successfully.
The Security Audit job fails on
main(and every open PR) after new RustSec advisories against pinned transitive deps.cargo auditis clean with this change; only the 8 pre-existing allowed warnings remain.quinn-protorustlsself_update→zipself_update1.3.1 is the first release onzip ^9; the features we use are unchanged andsrc/cli/update.rs/src/version_check.rscompile without edits. The quick-xml note on the old pin is superseded (1.3 is on quick-xml ≥ 0.41 as well).RUSTSEC-2026-0344 (
ruzstd0.8.3) is added to a new.cargo/audit.tomlignore list rather than fixed. It's reached only throughsubxt-lightclient→smoldot, an optional subxt feature this crate never enables, so it's inCargo.lockbut never compiled (cargo tree -i smoldot --target all -e allprints nothing). Everysmoldotrelease pinsruzstd ^0.8, so nothing on our side can bump it.Verified locally:
cargo audit(0.22.1, same as CI) clean,cargo clippy --workspace --all-targets --all-features --locked -D warningsclean, pinned-nightly fmt clean, update-module tests pass.Made with Cursor