Skip to content

teacher into engine - #52

Merged
Kristofferjoha merged 19 commits into
mainfrom
teacher
Nov 18, 2026
Merged

Kristofferjoha merged 19 commits into
mainfrom
teacher

Conversation

@tbdlarsen

Copy link
Copy Markdown
Contributor

No description provided.

Thorbjørn Larsen and others added 2 commits November 18, 2026 11:01
Shorten or remove verbose and obvious comments across the files this
branch touches, and fix comments that had gone stale (J5 -> J4, the
term-weighted scale, ranking kNN). No functional changes:

- remove unused <functional> include in objective.cpp
- rename arm locals in teacher_test to the current arm names
- brace two gtest asserts to fix -Wdangling-else
@tbdlarsen
tbdlarsen marked this pull request as ready for review November 18, 2026 17:40
@Kristofferjoha
Kristofferjoha merged commit b64347b into main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants