Repository navigation
Bugfix/watch knn - #61
Merged
Merged
Conversation
The loop accepts switches on the tracked J_T, whose kNN term only watches each query's top k plus its nearest others in the start and single-recipe states. In a mixed state an unwatched trajectory can enter a top k unseen, so a switch with a positive tracked gain can lower the real J_T. BUDGET_LOOP, EQUAL_LOOP and the loop inside each reallocation round now recompute exact J_T before and after, and keep the start if the loop lost. Adds a 200-trajectory, k = 3 test where the watch lists cover a small part of the database.
checked_loop takes the start's exact J_T when the caller has it and returns the result's, and keep() returns each arm's J_T and accepts a known one. With BUDGET_CHOICE (or EQUAL_CHOICE_RDP_PARTNERS) also requested the check needs no extra J_T evaluation, and a reallocation round reuses the check's value.
Contributor
Author
|
Check the loop's result against its start with exact J_T |
tbdlarsen
marked this pull request as ready for review
November 21, 2026 12:34
Kristofferjoha
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.