Repository navigation
Conversation
add_ranked_neighbours recomputed every neighbour's distance with frechet_distance: a full discrete Fréchet, then a bisection from 0 in 1 mm steps, about 20 continuous decisions per neighbour. The kNN search had already computed each distance on the 1 mm ranking grid, usually with one decision from its Hausdorff bound, and returned only indices. query::knn_with_distances returns those (index, distance) pairs, and query::knn now wraps it. The ranked lists use them directly, so their distances sit on the same grid as the ranking. The ranked cache magic is bumped, so caches with the old distances are rebuilt. On the 15 % Geolife sample (seed 42) building the ranked lists takes 327 s instead of 699 s. The lists hold the same neighbours in the same order, with distances within 1 mm. Runs that load the cache are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently doing run, should cut cache making time in half,
it does so by returning knn and distances when calculated, so we dont have to re-calculate for all queries, i.e., in the j_T checks.
will add symmetry for further speedup, i.e., distance from q1 to q2 is the same as distance from q2 to q1