Repository navigation
Use empty_ns() wrappers for xml2 XPath and child lookups - #847
Open
MichaelChirico wants to merge 1 commit into
Open
MichaelChirico wants to merge 1 commit into
MichaelChirico wants to merge 1 commit into
Conversation
Member
|
Interesting. After merging #846 and this, I will make a CRAN release. |
renkun-ken
approved these changes
Nov 10, 2026
renkun-ken
left a comment
renkun-ken
left a comment
Member
There was a problem hiding this comment.
Reviewed against #846; I found no correctness issues. The changed lookups operate on namespace-free parser XML, and explicit namespace overrides still work.
Local focused provider tests passed with R 4.6.1 and xml2 1.6.0. The parse, navigation, refactoring, semantic-token and pipe-hint suites also passed with the minimum supported xml2 1.2.2. A representative lookup benchmark showed the expected speedup. GitHub checks are still running or queued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies the {lintr} innovation to use these wrappers to avoid the notable overhead of {xml2} to pursue
nslookup by default in too many cases where it doesn't matter. See #846 (comment) for some sample timings.