TransferBench v1.70.02 - #357
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fix the rings summary to accurately report variable per-executor counts or validate/aggregate them.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates TransferBench to v1.70.01 with broader rings executor usage and safer multi-node smoketest defaults.
Changes:
- Defaults rings to all available subexecutors.
- Disables non-scalable collective smoketests by default.
- Updates versioning, documentation, changelog, and CodeQL setup.
File summaries
| File | Summary |
|---|---|
src/client/Presets/SmokeTest.hpp |
Adjusts multi-rank smoketest selection. |
src/client/Presets/Rings.hpp |
Uses all available subexecutors; summary reporting has an unresolved issue for heterogeneous counts. |
docs/reference/presets.rst |
Documents the new rings default. |
CMakeLists.txt |
Updates the fallback patch version. |
CHANGELOG.md |
Adds v1.70.01 release notes. |
.github/workflows/codeql.yml |
Simplifies Git installation. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gilbertlee-amd
approved these changes
Sep 14, 2026
AtlantaPepsi
force-pushed
the
candidate-1.70.01
branch
from
September 18, 2026 20:44
95c6a9b to
b511fd6
Compare
nileshnegi
reviewed
Sep 18, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Rings may resolve inconsistent subexecutor counts across ranks, causing validation failure.
Review details
Suppressed comments (1)
src/client/Presets/Rings.hpp:146
- With
NUM_SUB_EXEC=0, this now resolvesnumSubExecsindependently from each transfer's rank/GPU. However,RunTransfersrequires every rank's correspondingTransfer.numSubExecsto match rank 0, while this preset only validates equal GPU counts. A multi-rank run with different CU counts will therefore fail before execution with aNum SubExecutorsconsistency error; validate matching counts up front or choose one common count for all ranks.
t.numSubExecs = (numSubExecs > 0) ? numSubExecs : TransferBench::GetNumSubExecutors(t.exeDevice);
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Lite
gilbertlee-amd
requested changes
Sep 18, 2026
nileshnegi
approved these changes
Sep 18, 2026
AtlantaPepsi
force-pushed
the
candidate-1.70.01
branch
from
September 18, 2026 21:22
b511fd6 to
e986a3e
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Rings auto mode can fail when ranks have different subexecutor counts.
Review details
Suppressed comments (1)
src/client/Presets/Rings.hpp:146
- When
NUM_SUB_EXECis 0, this resolves each hop from the local GPU's executor. However,RunTransfersrequires each rank's corresponding Transfer, includingnumSubExecs, to match rank 0; this preset only validates that GPU counts match. A multi-rank run with the same GPU count but different CU counts will therefore fail inCheckMultiNodeTransferConsistencyrather than run. Please either reject heterogeneous subexecutor counts in auto mode with a preset-level error or resolve one common count before building the transfers.
t.numSubExecs = (numSubExecs > 0) ? numSubExecs : TransferBench::GetNumSubExecutors(t.exeDevice);
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Lite
gilbertlee-amd
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ringsto use all available executors by defaultsmoketesttests that don't scale well in multi-node, i.e. all-to-all, gather, broadcast