Repository navigation
fix(release): use configured Node version for CLI executables - #128
Conversation
|
@coderabbitai full review |
|
Fresh independent GPT-6 Astra high-level source integration GO for exact candidate Review task: The reviewer verified the complete local four-line deletion, both setup-vp selections from package.json, and the executable guard requiring Node 26.13.1. Removing the stale overrides is the smallest repair. The previously reviewed integration, fork behavior, application source, and version are unchanged. The explicit user Cursor SDK metadata exception is resolved. No tests, browser, edits, monitoring or delegation were performed by the reviewer. CI and CodeRabbit are still running on this SHA. They remain merge gates. Release builds/artifacts/checksums, npm publication/integrity, clean Alpine plain-npm installation, preflight, actual serve and GitHub draft publication remain separate gates after merge. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Action performed
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
Final merge gates pass at exact candidate Rechecked repository/head/base identities and CLEAN/MERGEABLE readiness against |
The 0.0.111 release build fails because the RTVision workflow overrides Node to 26.12.1 while upstream's executable build requires the root package.json version, now 26.13.1. Remove both Linux and Windows overrides so setup-vp's existing node-version-file configuration selects the required version.
This is the minimal release repair for the maintainer-authorized sync and publication workflow after merged PR #127. No separate issue is needed for the directly observed build failure. The complete diff deletes four workflow lines; application source and version 0.0.111 are unchanged. The tag, draft and npm version remain unused.
Validation: the failed job records setup-vp selecting Node 26.13.1 before the stale step override forces 26.12.1, which the executable guard rejects. Precommit formatting and lint passed. Required check:changed passed formatting and its selected two tests; its broad typecheck selection hit the packaged tsrs binary's lack of Linux musl support. CI owns repo-wide checks and is running on this candidate.
Primary and fresh independent GPT-6 Astra high-level source integration GO apply to exact candidate
e1e3b0a8843827bb3052922669c58287c842587c; Astra receipt. CodeRabbit's exact-SHA assessment reports no remaining merge-blocking risk beyond passing CI. Release builds/artifacts/checksums, npm publication/integrity, clean Alpine plain-npm installation, preflight and actual serve gates remain required before GitHub release publication.Model and harness: GPT-6.1 Sol through Codex in T3 Code; independent review by GPT-6 Astra.