Skip to content

fix(release): use configured Node version for CLI executables - #128

Merged
kalvenschraut merged 1 commit into
rtvisionfrom
fix/rtvision-release-node-0.0.111
Nov 15, 2026
Merged

kalvenschraut merged 1 commit into
rtvisionfrom
fix/rtvision-release-node-0.0.111

Conversation

@kalvenschraut

@kalvenschraut kalvenschraut commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

The 0.0.111 release build fails because the RTVision workflow overrides Node to 26.12.1 while upstream's executable build requires the root package.json version, now 26.13.1. Remove both Linux and Windows overrides so setup-vp's existing node-version-file configuration selects the required version.

This is the minimal release repair for the maintainer-authorized sync and publication workflow after merged PR #127. No separate issue is needed for the directly observed build failure. The complete diff deletes four workflow lines; application source and version 0.0.111 are unchanged. The tag, draft and npm version remain unused.

Validation: the failed job records setup-vp selecting Node 26.13.1 before the stale step override forces 26.12.1, which the executable guard rejects. Precommit formatting and lint passed. Required check:changed passed formatting and its selected two tests; its broad typecheck selection hit the packaged tsrs binary's lack of Linux musl support. CI owns repo-wide checks and is running on this candidate.

Primary and fresh independent GPT-6 Astra high-level source integration GO apply to exact candidate e1e3b0a8843827bb3052922669c58287c842587c; Astra receipt. CodeRabbit's exact-SHA assessment reports no remaining merge-blocking risk beyond passing CI. Release builds/artifacts/checksums, npm publication/integrity, clean Alpine plain-npm installation, preflight and actual serve gates remain required before GitHub release publication.

Model and harness: GPT-6.1 Sol through Codex in T3 Code; independent review by GPT-6 Astra.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS labels Nov 15, 2026
@kalvenschraut

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@kalvenschraut

Copy link
Copy Markdown
Member Author

Fresh independent GPT-6 Astra high-level source integration GO for exact candidate e1e3b0a8843827bb3052922669c58287c842587c, with no verified blockers. Primary GO is recorded in the PR body for the same SHA.

Review task: node:delegated-task:command%3Amcp%3A2a25a115-b7ab-433f-8f78-1a21998a9d37%3Adelegate-task%3Ac37d30de-a072-407c-aa76-aea27b806000; executed model gpt-6-astra.

The reviewer verified the complete local four-line deletion, both setup-vp selections from package.json, and the executable guard requiring Node 26.13.1. Removing the stale overrides is the smallest repair. The previously reviewed integration, fork behavior, application source, and version are unchanged. The explicit user Cursor SDK metadata exception is resolved. No tests, browser, edits, monitoring or delegation were performed by the reviewer.

CI and CodeRabbit are still running on this SHA. They remain merge gates. Release builds/artifacts/checksums, npm publication/integrity, clean Alpine plain-npm installation, preflight, actual serve and GitHub draft publication remain separate gates after merge.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release workflow removes the VP_NODE_VERSION environment override from the Linux and Windows CLI build steps.

Changes: Release workflow

Layer / File(s) Summary
CLI build environment
.github/workflows/rtvision-release.yml
The Linux and Windows CLI build steps no longer set VP_NODE_VERSION to 26.12.1.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to e1e3b

This removes stale Node version overrides so release builds use the version configured in the repository. No concrete merge-blocking risk was found; release-build success is confirmed only by CI and post-merge gates.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the release workflow now uses the configured Node version for CLI executable builds. The raw summary confirms the only change removes the Linux and Windows VP_NODE_VER…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the problem (0.0.111 release build fails because the workflow overrides Node to 26.12.1 while the executable build requires 26.13.1), the change (removing the Linux and Windows …
Full details: Title check

Explanation

The title names the main change: the release workflow now uses the configured Node version for CLI executable builds. The raw summary confirms the only change removes the Linux and Windows VP_NODE_VERSION overrides in rtvision-release.yml. The title's 'fix(release)' prefix is a conventional commit form, and the scope matches the file change.

Full details: Description check

Explanation

The description states the problem (0.0.111 release build fails because the workflow overrides Node to 26.12.1 while the executable build requires 26.13.1), the change (removing the Linux and Windows overrides so setup-vp uses node-version-file), and the scope (minimal release repair, no issue needed for the directly observed failure). It also gives verification: the failed job's Node selection, precommit format and lint passing, and check:changed passing formatting and two tests, with a broad typecheck failure explained. It names the model and harness. Gaps: the template's Verification section asks for focused tests and observed results for the changed behavior, which is partly met, but no run confirms the release build now passes. The Scope section cites a maintainer-authorized sync but does not link a maintainer request. The description also carries much release-process detail (GO receipts, npm and Alpine gates) that the template does not ask for. Core required information is present, so the check passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between db3e1da and e1e3b0a.

Files selected for processing: 1

  • .github/workflows/rtvision-release.yml
Files with no reviewable changes: 1

  • .github/workflows/rtvision-release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action performed

Full review finished.

@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.2 KiB 384.2 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: db3e1da · PR result: e1e3b0a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@kalvenschraut

Copy link
Copy Markdown
Member Author

Final merge gates pass at exact candidate e1e3b0a8843827bb3052922669c58287c842587c: primary and fresh GPT-6 Astra high-level source GO, completed CodeRabbit exact-SHA review with no concrete merge-blocking risk, no actionable or inline findings, and all applicable CI checks passing in run 43743519519. This uses CodeRabbit's written exact-SHA assessment, not merely its green status. The thread-transfer report is bound to this SHA; all enforced ceilings pass and all 64 additional measurements match the baseline.

Rechecked repository/head/base identities and CLEAN/MERGEABLE readiness against rtvision at db3e1dabf7f65efd56f45693dfaddcbb7d3f9624. Merging with ancestry preserved. Version 0.0.111 remains unused. Continue the release build from the exact merged tree, then verify all artifacts/checksums, exact npm publication/integrity, clean Alpine plain-npm install, preflight and actual serve before publishing the GitHub draft. No live service deployment or restart.

@kalvenschraut
kalvenschraut merged commit de9593b into rtvision Nov 15, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant