Repository navigation
fix: Correlate planned Docker stops before reporting crashes - #7
Merged
Merged
Conversation
rdwr-egore
marked this pull request as ready for review
October 14, 2026 15:16
This was referenced Oct 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix misleading CRITICAL crash / OOM guidance when Docker explicitly requests a container stop, but the application ignores SIGTERM and is eventually killed with exit 137. A SIGKILL exit is not evidence of OOM.
Scope after holistic PR integration
Explicitly deferred
These were removed to keep the correctness fix focused.
Validation
Important limits
A Docker stop event establishes a Docker-requested stop, not authorization. A missing or late stop event is treated conservatively as an unexpected crash. This PR does not prove that a stopped critical service should remain down.
Merge gate
Keep draft until GitHub CI (tests and Docker build) passes and compatibility with draft HA PR #4 is checked.