Skip to content

new atime ci, no more old cml container - #7901

Draft
tdhock wants to merge 7 commits into
masterfrom
new-atime-ci
Draft

tdhock wants to merge 7 commits into
masterfrom
new-atime-ci

Conversation

@tdhock

@tdhock tdhock commented Sep 18, 2026

Copy link
Copy Markdown
Member

The old atime CI uses an old container (old compilers etc.)
I propose switching to this new CI which is definitely more code.
Plus: easier to customize.
Minus: more maintenance burden.

@tdhock tdhock added the atime Requests related to adding/improving/monitoring performance regression tests via atime. label Sep 18, 2026
@tdhock

This comment was marked as outdated.

@tdhock tdhock mentioned this pull request Sep 18, 2026
@tdhock

This comment was marked as outdated.

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
  • HEAD=new-atime-ci much slower for isoweek improved in #7144
  • HEAD=new-atime-ci slower P<0.001 for fwrite refactored in #6393
    Comparison Plot

Generated via commit 4dc8c82

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 5 seconds
Installing different package versions 16 minutes and 54 seconds
Running and plotting the test cases 5 minutes and 15 seconds

GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: Anirban166/Autocomment-atime-results@v1.4.3 No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is designed to supplant the old action which can't be updated? Is there anything stopping us from forking it instead (or, if the current PR is intended as such a fork, could we at least host it in a dedicated repo under Rdatatable or maybe under your tdhock?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, the current PR is a fork. @Anirban166 would you consider putting this new code in your Autocomment-atime-results repo? (I was not sure if Ani is willing / able to continue maintenance, but that would be great)
The basic problem with the old action is that is uses an old cml container, old compilers, and this PR fixes that.

Comment thread .github/workflows/performance-tests.yml Outdated
Comment thread .github/workflows/performance-tests.yml

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

atime Requests related to adding/improving/monitoring performance regression tests via atime.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants