Repository navigation
Conversation
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The disk helper misclassifies SCM/UFS disks and cannot apply explicit false-valued filters.
Review effort: Balanced
Findings: None
What changed in this PR
Consolidates download operations under Invoke-RecastOSDDownloadFile and updates internal callers.
Changes:
- Renames the shared download helper and safely disposes
WebClient. - Migrates OS, driver-pack, and USB-cache downloads.
- Adds a separate deployment-disk enumeration helper.
| File | Description |
|---|---|
CHANGELOG.md |
Documents download-helper consolidation. |
OSDCloud/private/core/Invoke-RecastOSDDownloadFile.ps1 |
Renames and documents the shared helper. |
OSDCloud/private/core-cache/Update-RecastOSDCloudUSBCache.ps1 |
Migrates USB-cache downloads. |
OSDCloud/private/core-disk/Get-DeploymentDiskObject.ps1 |
Adds disk discovery and filtering. |
OSDCloud/private/steps/4-install/step-install-downloadwindowsimage.ps1 |
Migrates Windows image downloads. |
OSDCloud/private/steps/5-drivers/step-Save-WindowsDriver-DriverPack.ps1 |
Migrates driver-pack downloads. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: OSDeploy <12970006+OSDeploy@users.noreply.github.com>
Resolved the conflict and merged |
The merge conflicts are resolved in merge commit |
Unify download functions across scripts by consolidating the OSD and OSDCloud download helpers into a single function. This change improves code maintainability and usage consistency throughout the project.