Skip to content

Address setup-script and 23H2 review feedback #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OSDeploy merged 2 commits into from
Oct 5, 2026
Merged

Address setup-script and 23H2 review feedback #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
680c841
Initial plan
Copilot Oct 5, 2026
c0efd92
fix(deployment): address review comments
Copilot Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/instructions/workflow-tasks.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Each channel provides OS picker configuration per architecture.
{
"OperatingSystem": {
"default": "Windows 11 26H2",
"values": ["Windows 11 26H2", "Windows 11 25H2", "Windows 11 24H2"]
"values": ["Windows 11 26H2", "Windows 11 25H2", "Windows 11 24H2", "Windows 11 23H2"]
},
"OSActivation": {
"default": "Retail",
Expand Down
1 change: 1 addition & 0 deletions OSDCloud/private/steps/4-install/step-install-expandwindowsimage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ function step-install-expandwindowsimage {
try {
Write-Verbose -Message "[$(Get-Date -format s)] [$($MyInvocation.MyCommand.Name)] Running Expand-WindowsImage with parameters: $($Params | Out-String)"
Expand-WindowsImage @Params | Out-Null
New-Item -Path 'C:\Windows\Setup\Scripts' -ItemType Directory -Force | Out-Null
# Create SetupComplete.cmd if it does not exist
$setupCompletePath = 'C:\Windows\Setup\Scripts\SetupComplete.cmd'
if (-not (Test-Path $setupCompletePath)) {
Expand Down
2 changes: 1 addition & 1 deletion docs/01-overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Typical scenarios:
| Provision a new PC for Autopilot enrolment | **Yes** — deploy Windows, hand off to OOBE. See [guide 8](08-autopilot-oobe.md). |
| Deploy a custom corporate gold image | **No** — OSDCloud uses Microsoft ESDs. Use MDT/ConfigMgr or build a custom WIM. |
| Air-gapped network (no internet) | **No** — OSDCloud downloads ESDs and driver packs at runtime. |
| Deploy Windows 10 | **No** — current workflows target Windows 11 (26H2/25H2/24H2). |
| Deploy Windows 10 | **No** — the public default workflow targets Windows 11 (26H2/25H2/24H2/23H2). |

## Why use OSDCloud

Expand Down
2 changes: 1 addition & 1 deletion docs/04-deploy-windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ only what you need:

| Setting | Default | Notes |
|---|---|---|
| Operating System | Windows 11 26H2 | 25H2 and 24H2 also available |
| Operating System | Windows 11 26H2 | 25H2, 24H2, and 23H2 also available |
| Activation | Retail | Use Volume for VL/MAK keys |
| Edition | Pro | Home / Pro / Enterprise (+ Education and N variants on amd64) |
| Language | en-us | 38 codes (amd64) / 37 codes (arm64) |
Expand Down
4 changes: 2 additions & 2 deletions docs/05-customize-deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ A workflow is a folder under `OSDCloud/workflow/` that bundles:
- UI configuration.

The module currently supports the `default` workflow for public deployments.
Its settings allow Windows 11 26H2, 25H2, and 24H2 and use the standard
40-step task.
Its settings allow Windows 11 26H2, 25H2, 24H2, and 23H2 and use the
standard 40-step task.

The module also contains a `cli` folder for the internal preview CLI
implementation. It is not a supported GUI workflow or a replacement for
Expand Down
2 changes: 1 addition & 1 deletion docs/07-arm64-devices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ The `default` channel ships these ARM64 options (`workflow/default/os-arm64.json

| Setting | Default | Available values |
|---|---|---|
| Operating System | Windows 11 26H2 | 26H2, 25H2, 24H2 |
| Operating System | Windows 11 26H2 | 26H2, 25H2, 24H2, 23H2 |
| Activation | Retail | Retail, Volume |
| **Edition** | Pro | **Home, Pro, Enterprise only** — no N or Education editions |
| Language | en-us | 37 codes (no `bs-latn-ba` or `ms-my`) |
Expand Down
Loading