Skip to content

Stop deployment when setup scripts cannot be written #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OSDeploy merged 2 commits into from
Oct 6, 2026
Merged

Stop deployment when setup scripts cannot be written #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a726d
Initial plan
Copilot Oct 6, 2026
dd5e638
fix(deployment): stop on setup script failures
Copilot Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions OSDCloud/private/steps/4-install/step-install-expandwindowsimage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@ function step-install-expandwindowsimage {
try {
Write-Verbose -Message "[$(Get-Date -format s)] [$($MyInvocation.MyCommand.Name)] Running Expand-WindowsImage with parameters: $($Params | Out-String)"
Expand-WindowsImage @Params | Out-Null
New-Item -Path 'C:\Windows\Setup\Scripts' -ItemType Directory -Force | Out-Null
New-Item -Path 'C:\Windows\Setup\Scripts' -ItemType Directory -Force -ErrorAction Stop | Out-Null
# Create SetupComplete.cmd if it does not exist
$setupCompletePath = 'C:\Windows\Setup\Scripts\SetupComplete.cmd'
if (-not (Test-Path $setupCompletePath)) {
New-Item -Path $setupCompletePath -ItemType File -Force | Out-Null
New-Item -Path $setupCompletePath -ItemType File -Force -ErrorAction Stop | Out-Null
}
# Create SetupComplete.cmd
":: RecastOSDCloud $(Get-Date -format s)" | Out-File -FilePath $setupCompletePath -Append -Encoding ascii -Width 2000 -Force
":: RecastOSDCloud $(Get-Date -format s)" | Out-File -FilePath $setupCompletePath -Append -Encoding ascii -Width 2000 -Force -ErrorAction Stop
# Create OOBE.cmd
":: RecastOSDCloud $(Get-Date -format s)" | Out-File -FilePath 'C:\Windows\Setup\Scripts\OOBE.cmd' -Append -Encoding ascii -Width 2000 -Force
":: RecastOSDCloud $(Get-Date -format s)" | Out-File -FilePath 'C:\Windows\Setup\Scripts\OOBE.cmd' -Append -Encoding ascii -Width 2000 -Force -ErrorAction Stop
}
catch {
Write-Warning "[$(Get-Date -format s)] Expand-WindowsImage failed."
Expand Down
Loading