Repository navigation
Check the manifest metadata a dry run cannot see - #36
Merged
Merged
Conversation
…uploads
The second publish run failed at crate 7 of 16 with a different error:
error: failed to publish sephera_graph_cpp v0.7.1
status 400 Bad Request: expected at most 5 keywords per crate
`sephera_graph_cpp` carried seven keywords and `sephera_graph_javascript` six.
Every dry run was green, because a dry run does not upload and so never asks the
registry whether it would accept the manifest. The fact was readable in the
manifest the whole time.
Both are trimmed to five. For C++ that means dropping `c++` and `include`: `cpp`
is the convention on crates.io and the one a search actually finds, and `header`
names what the crate parses where `include` names a keyword inside the source.
For JavaScript that means dropping `npm`, the least relevant term to someone
looking for an import resolver.
`check_metadata` is new and runs in both the mode CI uses and the mode a real
publish uses, so this is caught by `publish_dry_run` rather than by a failed
upload at the seventh crate. It checks the keyword and category counts and that a
description exists, and reports rather than silently truncating -- a manifest
that declares seven keywords is a manifest somebody meant something by, and the
right response is to tell them which to drop.
Teeth: seven keywords in a manifest is caught by name and the script exits 1;
a missing description is caught the same way; both restore clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage and benchmarksLine coverage: 91.70% (15,438/16,835 lines) Benchmarks (5 measured runs per command)
Benchmark numbers come from a shared runner and compare within a run, not across runs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second publish run failed at crate 7 of 16 with a different error:
error: failed to publish sephera_graph_cpp v0.7.1 status 400 Bad Request: expected at most 5 keywords per crate\sephera_graph_cpp\ had seven keywords, \sephera_graph_javascript\ six. Every dry
run was green -- a dry run does not upload, so it never asks the registry whether it
would accept the manifest. The resume logic from #35 worked exactly as intended: the
six already-published crates were skipped and it went straight to the crate that was
going to fail.
Two things:
Both manifests trimmed to five keywords. C++ drops \c++\ and \include: \cpp
is the crates.io convention and what a search finds, and \header\ names what the
crate parses where \include\ names a keyword inside the source. JavaScript drops
pm, the least relevant term to someone looking for an import resolver.
\check_metadata\ is new, and it runs in the mode CI uses (\publish_dry_run) as
well as the mode a real publish uses. That is the point: this is now caught by the CI
job rather than by a failed upload at crate 7. It reports which keywords to drop
rather than truncating silently -- a manifest with seven keywords is one somebody
meant something by.
Teeth: seven keywords injected into a manifest is caught by name and the script
exits 1; a removed description is caught the same way; both restore clean.