Skip to content

Update instructions for creating game pages - #436

Merged
wescopeland merged 2 commits into
RetroAchievements:mainfrom
akleemans:patch-1
Oct 16, 2026
Merged

wescopeland merged 2 commits into
RetroAchievements:mainfrom
akleemans:patch-1

Conversation

@akleemans

Copy link
Copy Markdown
Contributor

Add detail "for the same system" for recycling game pages

Add detail "for the same system" for recycling game pages
@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This documentation clarification appears safe to merge.

Summary

Clarifies that recycled game pages must belong to the same system. No actionable issues found.

  • The guide points developers to recyclable pages from the same system.

Reviews (1) · Last reviewed commit: "Update instructions for creating game pa..." · Reviewed by Greptile

@akleemans

akleemans commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

The system of a Game entry can not be changed by a dev, so recycling only works for an entry which already has the same System.
Conversation in #dev-chat: https://discord.com/channels/310192285306454017/310195377993416714/1559484019421220872

@wescopeland

Copy link
Copy Markdown
Member

I agree with the change in spirit, but I'm actually wondering if we should remove this line altogether from the docs. Recycling is kind of an antipattern because it messes with denormalized data in the DB.

@tomojira thoughts?

@RALordAndrew

Copy link
Copy Markdown
Contributor

Recycling pages is discouraged in most cases now, but I don't think this is mentioned anywhere in the documentation. https://discord.com/channels/310192285306454017/386068797921951755/1509245235090297005

@akleemans

Copy link
Copy Markdown
Contributor Author

I guess it's better to remove it here then as wes suggests? This is the developer onboarding page, so if it's generally discouraged, I think it's best to remove it here.

@tomojira

Copy link
Copy Markdown
Contributor

Yeah, we could remove it. In that announcement I said it was still okay to recycle the ones named "No Hash" if there's minimal impact, so accidental duplicate pages wouldn't accumulate too much going forward. But maybe it's best to drop this altogether.

@akleemans

Copy link
Copy Markdown
Contributor Author

Updated PR, removed recycle part.

@wescopeland
wescopeland merged commit 00ac2b8 into RetroAchievements:main Oct 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants