Repository navigation
Update jr-dev-rules.md to include the jr-design-feedback forum - #442
Conversation
Currently, Junior Set Plan Reviews are conducted over on jr-design-feedback forum on Discord (https://discord.com/channels/310192285306454017/1538855563708997712), as opposed to the jr-devs-requests. Therefore, I am proposing this update on the Jr-Dev rules page to include the reference to the correct forum for set plan reviews.
 [Low impact] Updates a forum channel name in developer documentation. Safe to merge, with a non-blocking documentation follow-up. SummaryUpdates existing juniors' set-plan destination to
Reviews (1) · Last reviewed commit: "Update jr-dev-rules.md to include the jr..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - Submit your set plan for approval. While the set plan is not a final product, it must show a general outline of the planned set including progression, challenge, and other types of achievements. Brief descriptions and point values must be included as well. If during development significant deviations are made from the set plan, a revised set plan must be submitted for approval. | ||
| - If this is your first set as a junior, you have to submit this set plan in the #role-request forum on the [RetroAchievements Discord server](https://discord.gg/dq2E4hE), along with a link to your RA profile, a link to the page of the game you wish to work on, and a ping to @Code-Reviewer. | ||
| - If you already are in the junior program, you have to submit this set plan on #jr-devs-requests. As a junior developer with at least one set published, you may claim the game while you work on your set plan, but no work is allowed prior to having your plan approved. | ||
| - If you already are in the junior program, you have to submit this set plan on #jr-design-feedback. As a junior developer with at least one set published, you may claim the game while you work on your set plan, but no work is allowed prior to having your plan approved. |
There was a problem hiding this comment.
how-to-become-an-achievement-developer.md:22 still directs juniors to submit set plans in #jr-devs-requests. The two guides now give different destinations for the same step, so juniors can still follow the old instructions.
Suggestion: Update that instruction to use #jr-design-feedback for existing juniors too.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Maybe we should fix that one too @spooking96 - happy to merge it in another PR
There was a problem hiding this comment.
Yeah, this would need an update as well, but it would be necessary to explain that the first ever junior set would be evaluated on the #role-request forum, whereas the following ones would go on #jr-design-feedback. I will have a talk with the other CRs about this one though first.
There was a problem hiding this comment.
That distinction makes sense. The current change correctly updates the destination for existing junior developers; the other guide can be updated separately once the wording for first versus subsequent junior sets is agreed with the CRs.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
2 participants
Currently, Junior Set Plan Reviews are conducted over on jr-design-feedback forum on Discord (https://discord.com/channels/310192285306454017/1538855563708997712), as opposed to the jr-devs-requests.
Therefore, I am proposing this update on the Jr-Dev rules page to include the reference to the correct forum for set plan reviews.