Repository navigation
Conversation
Fixing a failed check no longer replaces the composer draft. Each check becomes an additive context chip, and Fix beside the failing count attaches every failing check in one chip. Thread details uses the same path. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixing a failed check from a pull request replaced the composer draft. There was also no way to add all failing checks to the composer in one action.
Change
Add each failed check as a separate composer context chip, preserving existing text and chips. Add a “Fix” button beside the failing count in the summary row that attaches one context chip listing the failing checks. The thread details row and its checks popover use the same Fix actions, so they add to the current thread's composer instead of opening a new thread. Check chips display check names and links correctly in composer and sent messages.
Scope and approval
This is a focused improvement to the existing pull request check fix workflow: the check actions now add context to the composer instead of replacing its draft.
Verification
Ran
vp run check:changed; formatting, lint, knip, affected package typechecks, tests, and React compiler checks passed. Manually verified adding multiple checks and all checks, draft persistence after restart and reload, sending through Replay, and check links in composer and sent message chips. Also verified the thread details row Fix and its checks popover in the dev app. Mobile presentation and standalone Pull requests page actions were not manually tested.Screenshots
Both use the same steps on pingdotgg#31514: type a note, then fix Test Web, then fix Check.
Before: the second fix replaced the first, the instructions filled the composer, and there was no way to target every check.
After: each check is a chip beside the typed note, and the summary row has a Fix button.
After Fix in the summary row: one more chip targets every failing check.
Chip details: opening a chip shows links to the checks, here on a sent message.
Thread details row: Fix uses the hammer instead of the new-thread arrow, and adds to this thread's composer.
Thread details checks popover: the same check rows and Fix buttons as the Checks section.
GPT-6 via Codex
🤖 Generated with Claude Code