Skip to content

feat(web): add failing checks to composer context chips - #34

Draft
wSedlacek wants to merge 2 commits into
mainfrom
t3/pr-checks-composer-links
Draft

wSedlacek wants to merge 2 commits into
mainfrom
t3/pr-checks-composer-links

Conversation

@wSedlacek

Copy link
Copy Markdown

Reopened from closed upstream PR pingdotgg#30659 as a draft for t3.1code.
Idea rank: 33 of 108. Branch is as it was upstream; it likely needs a rebase (modernize) before review.

Problem

Fixing a failed check from a pull request replaced the composer draft. There was also no way to add all failing checks to the composer in one action.

Change

Add each failed check as a separate composer context chip, preserving existing text and chips. Add a “Fix” button beside the failing count in the summary row that attaches one context chip listing the failing checks. The thread details row and its checks popover use the same Fix actions, so they add to the current thread's composer instead of opening a new thread. Check chips display check names and links correctly in composer and sent messages.

Scope and approval

This is a focused improvement to the existing pull request check fix workflow: the check actions now add context to the composer instead of replacing its draft.

Verification

Ran vp run check:changed; formatting, lint, knip, affected package typechecks, tests, and React compiler checks passed. Manually verified adding multiple checks and all checks, draft persistence after restart and reload, sending through Replay, and check links in composer and sent message chips. Also verified the thread details row Fix and its checks popover in the dev app. Mobile presentation and standalone Pull requests page actions were not manually tested.

Screenshots

Both use the same steps on pingdotgg#31514: type a note, then fix Test Web, then fix Check.

Before: the second fix replaced the first, the instructions filled the composer, and there was no way to target every check.

Composer filled with one check's instructions, with no Fix button beside the failing count

After: each check is a chip beside the typed note, and the summary row has a Fix button.

Composer showing the typed note with Test Web and Check chips, and Fix buttons in the summary row and on each failing check

After Fix in the summary row: one more chip targets every failing check.

Composer with Test Web, Check and Failing checks on pingdotgg/t3code#31514 chips

Chip details: opening a chip shows links to the checks, here on a sent message.

Popover titled Failing checks on pingdotgg/t3code#31514 with links to the three failing checks

Thread details row: Fix uses the hammer instead of the new-thread arrow, and adds to this thread's composer.

Thread details row for pingdotgg/t3code#31744 with a red Fix button, and the pingdotgg/t3code#31744 and Failing checks on pingdotgg/t3code#31744 chips in the composer

Thread details checks popover: the same check rows and Fix buttons as the Checks section.

Checks popover with a Fix button in the header and beside the failing check

GPT-6 via Codex

🤖 Generated with Claude Code

wSedlacek and others added 2 commits November 9, 2026 10:16
Fixing a failed check no longer replaces the composer draft. Each check
becomes an additive context chip, and Fix beside the failing count attaches
every failing check in one chip. Thread details uses the same path.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XL labels Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants