Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep images on expanded slash commands, rebuild messages on resume and after a rewind, fork from the source session's own history, and bound the CLI when it stops responding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bound Copilot text generation startup too, so a stalled CLI is force stopped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A fork leaves another session active, so a rewind could hit the wrong session or report success without truncating anything. Also stop the CLI when text generation is interrupted, and keep provider text out of the stop error detail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review guides need to read the checkout, so these sessions get read-only tools. Copilot runs commands it considers read-only without asking, including git diff --output, so a pre-tool hook enforces the limit on every call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move git to an allow list: git diff compares files anywhere once a path leaves the checkout, even without --no-index. Treat unknown tool arguments as paths and resolve symlinks, so a change request cannot point a read outside the checkout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The SDK starts the CLI without a shell, so npm's shim fails with spawn EINVAL. Launch the binary behind it instead. Review guides stay off on Windows because their read-only rules are written for bash, and Copilot's shell there is PowerShell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Autopilot can finish while background work is still running, so end the turn on session.autopilot_stopped. Also keep MCP App failures as cause without copying their message, and resolve project-local .bin shims on Windows. Co-authored-by: Cursor <cursoragent@cursor.com>
Subagent turn_start/idle were flipping mainAgentBusy and clearing the steered mark, so steers interrupted idle mains or settled as cancelled. Guard root-agent state on missing agentId (from NicL9923) and cover Autopilot error settles. Co-authored-by: Cursor <cursoragent@cursor.com>
pnpm install failed with ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY for @effect/vitest after the main merge left an incomplete lockfile entry. Co-authored-by: Cursor <cursoragent@cursor.com>
…der with the target run
HistorySwipeNavigation only attaches on macOS, so the tab-strip flick test never navigated on Linux CI and failed after pingdotgg#33396. Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # packages/provider-acp/src/server/adapter.ts
github-actions
Bot
added
vouch:trusted
|
This PR changes the test suite by +58 test cases (browser 0, unit +54, server +4). Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on pingdotgg#32221 (includes that PR until it lands). Prefer reviewing only the Windows commits.
Problem
The GitHub Copilot provider from pingdotgg#32221 refuses to start on Windows. The SDK starts the CLI without a shell, so the
copilot.cmdshim from an npm install fails withspawn EINVAL.Change
T3 now launches the
copilot.exebehind npm's shim, so the provider runs on Windows.bash, and Copilot's shell there ispowershell. They fail with the existing "choose another model" message until those rules can be tested on a live agent.copilot login.C:/secretare refused in the review guide rules. They were only unreachable on Windows because the shell tool is unavailable there.Scope and approval
This depends on pingdotgg#32221, which has no explicit maintainer approval yet, so it needs the same decision on direction and scope.
Verification
vp run check:changedpasses on macOS. I ran the rest on GitHub-hostedwindows-latestmachines through a temporary fork workflow, with no secrets and no Copilot login, using@github/copilot1.0.107 installed with npm on x64.copilot.cmddirectlyspawn EINVALcopilot.CMDto thecopilot.exebehind itinstalled but not signed in. Run copilot login, in about 12spackages/provider-copilotserver testspowershell, notbashNot checked:
models.liston that signed-out machine.There is no UI change to show.
Created with Opus 5.5 in Claude Code.
🤖 Generated with Claude Code
🤖 Generated with Claude Code