Skip to content

fix(mobile): keep empty searches closed when reopening Home - #89

Draft
wSedlacek wants to merge 1 commit into
mainfrom
t3/fix-mobile-search-reopening
Draft

wSedlacek wants to merge 1 commit into
mainfrom
t3/fix-mobile-search-reopening

Conversation

@wSedlacek

Copy link
Copy Markdown

Reopened from closed upstream PR pingdotgg#32095 as a draft for t3.1code.
Idea rank: 88 of 108. Branch is as it was upstream; it likely needs a rebase (modernize) before review.

Problem

Returning to Home after opening a thread could reopen an empty search field. This happened when the thread covered Home before the search field's blur updated its state. On iOS, the integrated search could also leave an empty field in expanded mode after closing it.

Change

On iOS, restore native search only when a query remains or the Duo keeps an empty search open, and autofocus only when search should be restored. On Android, close empty thread and pull request searches when Home is covered. Added focused state coverage for empty search restoration.

Scope and approval

This is a focused fix for an obvious mobile search bug. The changes are limited to mobile search state and toolbars on iOS and Android.

Verification

The focused unit tests and check:changed passed. On an iPhone 17 Pro, opening search, opening a thread, and returning to Home left search closed. Query search still restores on return. Web and desktop are not applicable.

GPT-6 / Codex

🤖 Generated with Claude Code

Reopened from pingdotgg#32095 and squashed onto current main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wSedlacek
wSedlacek force-pushed the t3/fix-mobile-search-reopening branch from cc19381 to 349237e Compare November 14, 2026 22:46
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M labels Nov 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant