Separate preview builds from AWS publishing - #17
Conversation
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 663a31d833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR builds currently run installation and extension code with AWS deployment credentials available. Split that flow into a credential-free dry build and a separate preview publisher, using the pattern already implemented in Pinned Blocks.
pr.yamlto build and uploaddistas a GitHub artifact with read-only repository permissions.pr-preview.yamlto publish successful same-repository PR artifacts to the existing exact-case and lowercase Samepage/S3 paths without checking out or executing PR code.npm install: the existing lockfile causesnpm cito fail with an Android-only esbuild dependency.Validation: local dependency installation,
samepage build --dry(0 errors), actionlint, Prettier, andgit diff --checkpass. Local installation used--package-lock=falseto preserve the existing lockfile. A mocked AWS invocation test also passes for mixed-case filenames, nested paths, spaces, and an already-lowercase destination prefix; trigger/concurrency assertions pass. No real upload was performed. The privileged upload requires a post-merge check because GitHub activatesworkflow_runfrom the default branch.This PR contains only the two preview workflows and is independent of the Craft compatibility PR #16. Production publishing is unchanged.