Skip to content

Separate preview builds from AWS publishing - #17

Merged
mdroidian merged 2 commits into
mainfrom
codex/presentation-preview-workflow
Sep 13, 2026
Merged

mdroidian merged 2 commits into
mainfrom
codex/presentation-preview-workflow

Conversation

@mdroidian

@mdroidian mdroidian commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

PR builds currently run installation and extension code with AWS deployment credentials available. Split that flow into a credential-free dry build and a separate preview publisher, using the pattern already implemented in Pinned Blocks.

  • Update pr.yaml to build and upload dist as a GitHub artifact with read-only repository permissions.
  • Add pr-preview.yaml to publish successful same-repository PR artifacts to the existing exact-case and lowercase Samepage/S3 paths without checking out or executing PR code.
  • Run builds for every PR targeting main, including configuration-only changes, and isolate publisher concurrency by source repository and branch.
  • Lowercase full object keys, including filenames, while retaining exact-case uploads.
  • Preserve Presentation's npm install: the existing lockfile causes npm ci to fail with an Android-only esbuild dependency.

Validation: local dependency installation, samepage build --dry (0 errors), actionlint, Prettier, and git diff --check pass. Local installation used --package-lock=false to preserve the existing lockfile. A mocked AWS invocation test also passes for mixed-case filenames, nested paths, spaces, and an already-lowercase destination prefix; trigger/concurrency assertions pass. No real upload was performed. The privileged upload requires a post-merge check because GitHub activates workflow_run from the default branch.

This PR contains only the two preview workflows and is independent of the Craft compatibility PR #16. Production publishing is unchanged.


Devin Review

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: d5993ac9-b832-45f1-aab8-8bf58677a4ab

📥 Commits

Reviewing files that changed from the base of the PR and between 3825961 and 5c7d5ec.

📒 Files selected for processing (2)
  • .github/workflows/pr-preview.yaml
  • .github/workflows/pr.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T19:50:42.536894Z 5c7d5ec New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread .github/workflows/pr-preview.yaml Outdated
Comment thread .github/workflows/pr.yaml Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 663a31d833

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/pr.yaml Outdated
Comment thread .github/workflows/pr-preview.yaml Outdated
@mdroidian
mdroidian merged commit f561702 into main Sep 13, 2026
2 checks passed
@mdroidian
mdroidian deleted the codex/presentation-preview-workflow branch September 13, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant