Conversation
Contributor
|
Hello, thank you for your contribution. This is definitely something cpal needs (#106), and it just so happens that revamping the API to accomodate backend specific features (#1334), under which exclusive mode falls, is the primary goal for the next major release (#1220). I'd suggest that we postpone this PR until the new API is in place, so we don't have to iterate on API design choices twice in a row |
Author
|
Happy to wait on it until the API is firmed up. And happy to help out where I can. We rely heavily on you folks and are grateful for the work you've done / are doing so we can concentrate on the other bits. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I'm one of the maintainers of the sendspin-rs library, an audio library used by the Music Assistant desktop client across Windows, Linux, and macOS. We've been getting requests to support exclusive mode and I saw that there had been previous attempts that were acceptable in theory, just needed to get through the PR process.
Anyway, this is that. I created branches in sendspin-rs and the MA desktop client to test it end to end, using a Windows ARM VM and a Schiit USB DAC. If this approach is acceptable I'll follow-up with another PR for CoreAudio 'hog mode'. I haven't even looked at Linux yet but I presume there's something similar there, and I can do that as well. Also, this initial PR is purely output not input, which I can also follow-up with if this approach is acceptable for you folks.