Repository navigation
Blind signing paths by default; deprecate pss::BlindedSigningKey - #758
Merged
Merged
Conversation
Similar change to #739, but for signing instead of decryption, utilizing `getrandom` when available to supply randomness for blinding automatically when the crate feature is enabled (which it is by default). This also changes `pss::BlindedSigningKey` into a deprecated type alias for `pss::SigningKey`. Contrary to a code comment claiming that it's an implementation of `draft-irtf-cfrg-rsa-blind-signatures` (now RFC9474) it doesn't actually implement this protocol but merely blinds the signing paths, now making it redundant. A proper implementation of RFC9474 blinded signatures would be interesting to add, but the API would need to receive an already encoded and blinded representative from the client, and we don't support that.
tarcieri
force-pushed
the
blind-signing-paths
branch
from
November 2, 2026 18:01
ee4829c to
9a71ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar change to #739, but for signing instead of decryption, utilizing
getrandomwhen available to supply randomness for blinding automatically when the crate feature is enabled (which it is by default).This also changes
pss::BlindedSigningKeyinto a deprecated type alias forpss::SigningKey. Contrary to a code comment claiming that it's an implementation ofdraft-irtf-cfrg-rsa-blind-signatures(now RFC9474) it doesn't actually implement this protocol but merely blinds the signing paths, now making it redundant.A proper implementation of RFC9474 blinded signatures would be interesting to add, but the API would need to receive an already encoded and blinded representative from the client, and we don't support that.