Repository navigation
Fix modulus 1 branch in BoxedMontyParams::new - #1401
Merged
Merged
Conversation
tarcieri
force-pushed
the
fix-modulus-one-branch-in-boxedmontyparams
branch
from
November 9, 2026 02:07
188a5ee to
9028f9a
Compare
Use `conditional_set_zero` for the modulus `1` correction, avoiding secret-dependent control flow and allocation. Thanks to @rldyourmnd for reporting this issue.
tarcieri
force-pushed
the
fix-modulus-one-branch-in-boxedmontyparams
branch
from
November 9, 2026 02:07
9028f9a to
b179b13
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1401 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 190 190
Lines 23428 23429 +1
=======================================
+ Hits 21500 21501 +1
Misses 1928 1928 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
conditional_set_zerofor the modulus1correction, avoiding secret-dependent control flow and allocation.Thanks to @rldyourmnd for reporting this issue.