Repository navigation
Document missing script recovery during Play - #42
Merged
Merged
Conversation
JamieW105
added
area:website
JamieW105
added a commit
to Rustic-Game-Engine/engine
that referenced
this pull request
Oct 14, 2026
Deleting an attached/startup script or an HTML-linked JavaScript file previously aborted Play. Skip missing manifest references and source files with a runtime warning, keep the remaining scripts running, and do not retry missing scripts during that play session. Snapshot creation and manual reload also skip missing source files. Other I/O, validation and path containment errors remain errors. Regression coverage checks global, scene and object scopes for missing IDs/files, continued ticks without retries, HTML links alongside inline code, and rejection of invalid UTF-8, directories and escaping paths. Validation: 74 engine-play library tests passed with the bundled Luau host built locally; rustic-editor compile check, Clippy for both affected packages/all targets with warnings denied, formatting and diff checks passed. Companion documentation: Rustic-Game-Engine/docs#42 (lint, build, TypeScript, audit and docs/link checks passed). Windows CI follow-up: run unit/integration/doc tests serially on Windows so concurrent native adapter compilation and processes do not contend within the existing three-second callback deadline. Linux retains parallel execution. Local serial validation: 74 engine-play library tests passed. Windows unit/integration/doc tests, rendered viewport verification, and all-target checks passed. A fresh Windows installer was built, tested, and uploaded (`RusticGameEngine-Setup-0.1.0-x64-20261014-214047.exe`). CI run: https://github.com/Rustic-Game-Engine/engine/actions/runs/38640755836.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a linked or startup script is deleted, Play now skips it and keeps the remaining scripts running. Document the warning, supported script scopes, lack of retries during the session, and editor steps to restore or replace the missing attachment.
Validation: lint with zero warnings, production build, TypeScript check, dependency audit (zero vulnerabilities), and documentation structure/link checks passed.
Companion engine fix: Rustic-Game-Engine/engine#37.