Repository navigation
fix: change system type label - #375
Merged
Merged
Conversation
NicoleMGomes
previously approved these changes
Oct 6, 2026
NicoleMGomes
approved these changes
Oct 6, 2026
NicoleMGomes
requested changes
Oct 6, 2026
NicoleMGomes
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix label key mismatch in
list_active_integrations: the read side was looking upsap-managed-runtime-system-type, but the write side (SPII system handler) stamps fragments withsap-managed-runtime-assigned-application-namespace. As a result,ConnectedSystem.system_typealways returnedNonefor every connected system.The fix aligns
_LABEL_SYSTEM_TYPEin_fragments.pywith the key actually written to the Destination Service fragment, and updates the corresponding unit test mock to use the correct key.Related Issue
Closes #<issue_number>
Type of Change
How to Test
agw_client.list_active_integrations()on a tenant with at least one connected backend system.ConnectedSystementries have a non-Nonesystem_typefield (e.g."sap.pce").uv run pytest tests/agentgateway/ -q— all 273 tests should pass.Checklist
Breaking Changes
None. The
system_typefield was alwaysNonebefore this fix, so populating it correctly is purely additive.Additional Notes
The label key
sap-managed-runtime-assigned-application-namespaceis defined asFragmentLabelKey.ASSIGNED_APPLICATION_NAMESPACEin the internal SPII SDK and must stay in sync with_LABEL_SYSTEM_TYPEin this repo. There is no shared contract between the two — if the key is ever renamed on the write side, the read side will silently regress to returningNoneagain.